Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add link buttons #371

Closed
miguelcobain opened this issue May 11, 2016 · 5 comments
Closed

add link buttons #371

miguelcobain opened this issue May 11, 2016 · 5 comments

Comments

@miguelcobain
Copy link
Collaborator

It should be trivial to add link support to buttons right now.

Example: https://ember-twiddle.com/#/6265da0fd9a1252423b383d3e33ddaf3?openFiles=components.my-component.js%2Ctemplates.components.my-component.hbs

@joukevandermaas
Copy link
Contributor

Also see #207 for a somewhat related discussion.

@miguelcobain
Copy link
Collaborator Author

To cover link-to functionality we're using https://github.com/peec/ember-transition-helper
Is that acceptable for the recommended solution?

@DanChadwick
Copy link
Contributor

I'm confused. Your button-turned-into-an-a-link component looks like an a link. I was under the impression that the only way to make a browser actually process an href was inside an a link, and with AM CSS, a links don't look anything like buttons. Are you suggesting that we add a bunch of e-p specific CSS to accomplish this?

@miguelcobain
Copy link
Collaborator Author

miguelcobain commented May 11, 2016

@DanChadwick AM does have link buttons (buttons with an anchor tag): https://material.angularjs.org/1.0.6/demo/button

Turns out the styles are also applied to a tags.

The idea is to make paper-button use a tagName: 'a' if an href is present, like the linked twiddle suggests. We don't need another component.

@DanChadwick
Copy link
Contributor

Closed in favor of discussion in PR #372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants