Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert all components using ember-composability-tools to glimmer #1292

Open
16 of 20 tasks
matthewhartstonge opened this issue Oct 29, 2024 · 0 comments · Fixed by #1294 or #1293 · May be fixed by #1298, #1299 or #1300
Open
16 of 20 tasks

Convert all components using ember-composability-tools to glimmer #1292

matthewhartstonge opened this issue Oct 29, 2024 · 0 comments · Fixed by #1294 or #1293 · May be fixed by #1298, #1299 or #1300
Assignees

Comments

@matthewhartstonge
Copy link
Contributor

matthewhartstonge commented Oct 29, 2024

Todo

Mixins

There are a number of mixins that each of these components extend from which will need to be unwound as part of the work.

Parent Components

Children Components

Proxiable Components

Understanding the hierarchy:

Image

native ember

The following on ember-render-modifiers gives an example of how to migrate these components using ember/glimmer native primitives and patterns

https://github.com/emberjs/ember-render-modifiers#example-ember-composability-tools-style-rendering

PR Ordering

I've 'stacked' these PRs to minimise the amount needed to be reviewed, but each item requires the changes made before:

@matthewhartstonge matthewhartstonge converted this from a draft issue Oct 29, 2024
@matthewhartstonge matthewhartstonge changed the title Convert all components using ember-composability-helpers to glimmer Convert all components using ember-composability-tools to glimmer Oct 29, 2024
@matthewhartstonge matthewhartstonge self-assigned this Nov 11, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in ember-paper@v1 release Nov 15, 2024
@matthewhartstonge matthewhartstonge moved this from Done to In progress in ember-paper@v1 release Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment