Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a "showcase" page with at least one copy/variant of each component so we can snapshot them with Percy on PRs #1289

Closed
matthewhartstonge opened this issue Oct 29, 2024 · 1 comment · Fixed by #1288
Closed

Create a "showcase" page with at least one copy/variant of each component so we can snapshot them with Percy on PRs #1289

matthewhartstonge opened this issue Oct 29, 2024 · 1 comment · Fixed by #1288
Assignees
@matthewhartstonge

Comments

@matthewhartstonge
Copy link
Contributor

matthewhartstonge commented Oct 29, 2024 •
edited
Loading

Using Percy snapshots we can detect issues as we alter code to ensure no breaking changes.

  • currently on branch feature/widget-showcase.
  • Have copied over all widgets from the current showcase, but simplified (made less dynamic) for display of different modes.
@matthewhartstonge matthewhartstonge self-assigned this Oct 29, 2024
@matthewhartstonge matthewhartstonge converted this from a draft issue Oct 29, 2024
@matthewhartstonge matthewhartstonge linked a pull request Oct 29, 2024 that will close this issue
feat: adds widget catalog #1288
Merged
@matthewhartstonge matthewhartstonge moved this from In progress to In review in ember-paper@v1 release Oct 29, 2024
@matthewhartstonge
Copy link
Contributor Author

matthewhartstonge commented Oct 29, 2024 •
edited
Loading

I have not added the widget showcase/catalog into to the main menu, but we can if we want to. :)

Known Issues

  • Unsure of how to get <PaperMenu> to start popped open so we can get a snapshot of it.
  • Unsure of how to get <PaperSelect> to start popped open so we can get a snapshot of it.
  • I was unable to think of a way to get <PaperTooltip> to render on load.
    • overriding the internal @renderTooltip felt bad and caused explosions.

@github-project-automation github-project-automation bot moved this from In review to Done in ember-paper@v1 release Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewhartstonge matthewhartstonge

Labels
None yet
Projects
ember-paper@v1 release
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: adds widget catalog adopted-ember-addons/ember-paper
1 participant
@matthewhartstonge