From 07758cef5236baa2bbe33f05e2d5394569ef13d1 Mon Sep 17 00:00:00 2001 From: Matthew Hartstonge Date: Fri, 4 Oct 2024 11:55:01 +1300 Subject: [PATCH 01/31] fix(addon/components/paper-button): remove no-implicit-this. --- addon/components/paper-button.hbs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/addon/components/paper-button.hbs b/addon/components/paper-button.hbs index 10ba7b34f..79afe4288 100644 --- a/addon/components/paper-button.hbs +++ b/addon/components/paper-button.hbs @@ -1,8 +1,8 @@ -{{! template-lint-disable no-curly-component-invocation no-implicit-this }} +{{! template-lint-disable no-curly-component-invocation }} {{#if (has-block)}} {{yield}} {{else}} - {{label}} + {{@label}} {{/if}} Date: Fri, 4 Oct 2024 11:55:14 +1300 Subject: [PATCH 02/31] fix(addon/components/paper-card-media): remove no-implicit-this. --- addon/components/paper-card-media.hbs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/addon/components/paper-card-media.hbs b/addon/components/paper-card-media.hbs index ff4629985..eb1835447 100644 --- a/addon/components/paper-card-media.hbs +++ b/addon/components/paper-card-media.hbs @@ -1,8 +1,7 @@ -{{! template-lint-disable no-implicit-this }} {{#if (has-block)}} -
+
{{yield}}
{{else}} - {{alt}} + {{@alt}} {{/if}} \ No newline at end of file From 8dbdd8b9b28f8bfe7cbc0f973469bfd4c95bb27e Mon Sep 17 00:00:00 2001 From: Matthew Hartstonge Date: Fri, 4 Oct 2024 11:56:08 +1300 Subject: [PATCH 03/31] fix(addon/components/paper-card-title-media): remove no-implicit-this. --- addon/components/paper-card-title-media.hbs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/addon/components/paper-card-title-media.hbs b/addon/components/paper-card-title-media.hbs index ff4629985..eb1835447 100644 --- a/addon/components/paper-card-title-media.hbs +++ b/addon/components/paper-card-title-media.hbs @@ -1,8 +1,7 @@ -{{! template-lint-disable no-implicit-this }} {{#if (has-block)}} -
+
{{yield}}
{{else}} - {{alt}} + {{@alt}} {{/if}} \ No newline at end of file From f17ca15379be70b4273bbc512b79a163f3c27c7f Mon Sep 17 00:00:00 2001 From: Matthew Hartstonge Date: Fri, 4 Oct 2024 12:32:38 +1300 Subject: [PATCH 04/31] fix(addon/components/paper-checkbox): remove no-implicit-this. --- addon/components/paper-checkbox.hbs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/addon/components/paper-checkbox.hbs b/addon/components/paper-checkbox.hbs index 4348a6b98..09128b63d 100644 --- a/addon/components/paper-checkbox.hbs +++ b/addon/components/paper-checkbox.hbs @@ -1,4 +1,4 @@ -{{! template-lint-disable no-curly-component-invocation no-implicit-this }} +{{! template-lint-disable no-curly-component-invocation }}
{{#if (has-block)}}
- + {{yield}}
{{else}}
- - {{label}} + + {{@label}}
{{/if}} From 2e918b91b7b18258fe8da595c343fe7daf3f574b Mon Sep 17 00:00:00 2001 From: Matthew Hartstonge Date: Fri, 4 Oct 2024 12:47:50 +1300 Subject: [PATCH 05/31] fix(addon/components/paper-contact-chips): remove no-implicit-this. --- addon/components/paper-contact-chips/template.hbs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/addon/components/paper-contact-chips/template.hbs b/addon/components/paper-contact-chips/template.hbs index 2f6a22a76..628966778 100644 --- a/addon/components/paper-contact-chips/template.hbs +++ b/addon/components/paper-contact-chips/template.hbs @@ -1,4 +1,3 @@ -{{! template-lint-disable no-implicit-this }} - {{get + {{get
- {{get item nameField}} + {{get item this.nameField}} {{/if}} From eaeba73d2df4d52365e274082b5b3e9c584b4390 Mon Sep 17 00:00:00 2001 From: Matthew Hartstonge Date: Fri, 4 Oct 2024 12:53:00 +1300 Subject: [PATCH 06/31] fix(addon/components/paper-dialog): remove no-implicit-this. --- addon/components/paper-dialog.hbs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/addon/components/paper-dialog.hbs b/addon/components/paper-dialog.hbs index a57646227..288562901 100644 --- a/addon/components/paper-dialog.hbs +++ b/addon/components/paper-dialog.hbs @@ -1,8 +1,8 @@ -{{! template-lint-disable no-action no-implicit-this }} -{{#in-element destinationEl insertBefore=null}} - - - +{{! template-lint-disable no-action }} +{{#in-element this.destinationEl insertBefore=null}} + + + {{yield}} From bc735d45c26c5e80ceb74e236de3f257c1a750a9 Mon Sep 17 00:00:00 2001 From: Matthew Hartstonge Date: Fri, 4 Oct 2024 12:54:49 +1300 Subject: [PATCH 07/31] fix(addon/components/paper-form): remove no-implicit-this. --- addon/components/paper-form.hbs | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/addon/components/paper-form.hbs b/addon/components/paper-form.hbs index a779b13a9..7211e91f2 100644 --- a/addon/components/paper-form.hbs +++ b/addon/components/paper-form.hbs @@ -1,21 +1,21 @@ -{{! template-lint-disable no-action no-implicit-this }} +{{! template-lint-disable no-action }} {{yield (hash - isValid=isValid - isInvalid=isInvalid - isTouched=isTouched - isInvalidAndTouched=isInvalidAndTouched - input=(component inputComponent + isValid=this.isValid + isInvalid=this.isInvalid + isTouched=this.isTouched + isInvalidAndTouched=this.isInvalidAndTouched + input=(component this.inputComponent parentComponent=this onValidityChange=(action "localOnValidityChange") ) - submit-button=(component submitButtonComponent + submit-button=(component this.submitButtonComponent type="submit" ) - select=(component selectComponent + select=(component this.selectComponent parentComponent=this onValidityChange=(action "localOnValidityChange") ) - autocomplete=(component autocompleteComponent + autocomplete=(component this.autocompleteComponent parentComponent=this onValidityChange=(action "localOnValidityChange") ) From 041f0a7e06aee9871a9571ab842a76a12824b6ee Mon Sep 17 00:00:00 2001 From: Matthew Hartstonge Date: Fri, 4 Oct 2024 12:56:29 +1300 Subject: [PATCH 08/31] fix(addon/components/paper-icon): remove no-implicit-this. --- addon/components/paper-icon.hbs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/addon/components/paper-icon.hbs b/addon/components/paper-icon.hbs index b463a6d2d..132416f12 100644 --- a/addon/components/paper-icon.hbs +++ b/addon/components/paper-icon.hbs @@ -1,3 +1,2 @@ -{{! template-lint-disable no-implicit-this }} -{{-paper-underscore iconClass}} +{{-paper-underscore this.iconClass}} {{yield}} From f6fc41718c3553090778cb5a6da727d6065792f6 Mon Sep 17 00:00:00 2001 From: Matthew Hartstonge Date: Fri, 4 Oct 2024 13:16:54 +1300 Subject: [PATCH 09/31] fix(addon/components/paper-input): currentLength was not defined, therefore never yielded correctly in the returned hash. --- addon/components/paper-input.hbs | 2 +- addon/components/paper-input.js | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/addon/components/paper-input.hbs b/addon/components/paper-input.hbs index 4ed134c4b..508fb5fa5 100644 --- a/addon/components/paper-input.hbs +++ b/addon/components/paper-input.hbs @@ -85,7 +85,7 @@ {{#unless hideAllMessages}}
{{#if maxlength}} -
{{renderCharCount}}
+
{{this.currentLength}}/{{@maxlength}}
{{/if}}
{{#if isInvalidAndTouched}} diff --git a/addon/components/paper-input.js b/addon/components/paper-input.js index c4c8d0587..1d2f97dcd 100644 --- a/addon/components/paper-input.js +++ b/addon/components/paper-input.js @@ -76,9 +76,8 @@ export default Component.extend( }, }), - renderCharCount: computed('value', function () { - let currentLength = this.value ? this.value.length : 0; - return `${currentLength}/${this.maxlength}`; + currentLength: computed('value', function () { + return this.value ? this.value.length : 0; }), hasLeftIcon: bool('icon'), From 431efc08a0284f7aa3d14c1937a2277dc6dd7bf0 Mon Sep 17 00:00:00 2001 From: Matthew Hartstonge Date: Fri, 4 Oct 2024 13:17:55 +1300 Subject: [PATCH 10/31] fix(addon/components/paper-input): remove no-implicit-this. --- addon/components/paper-input.hbs | 168 +++++++++++++++---------------- 1 file changed, 84 insertions(+), 84 deletions(-) diff --git a/addon/components/paper-input.hbs b/addon/components/paper-input.hbs index 508fb5fa5..5ae43792e 100644 --- a/addon/components/paper-input.hbs +++ b/addon/components/paper-input.hbs @@ -1,97 +1,97 @@ -{{! template-lint-disable no-action no-curly-component-invocation no-down-event-binding no-implicit-this no-positive-tabindex }} -{{#if label}} - +{{! template-lint-disable no-action no-curly-component-invocation no-down-event-binding no-positive-tabindex }} +{{#if @label}} + {{/if}} -{{#if icon}} - {{component iconComponent icon}} +{{#if @icon}} + {{component this.iconComponent @icon}} {{/if}} -{{#if textarea}} +{{#if @textarea}} + name={{@passThru.name}} + rows={{@passThru.rows}} + cols={{@passThru.cols}} + maxlength={{@passThru.maxlength}} + tabindex={{@passThru.tabindex}} + title={{@title}} + required={{@passThru.required}} + selectionEnd={{@passThru.selectionEnd}} + selectionStart={{@passThru.selectionStart}} + selectionDirection={{@passThru.selectionDirection}} + wrap={{@passThru.wrap}} + readonly={{@passThru.readonly}} + form={{@passThru.form}} + spellcheck={{@passThru.spellcheck}}> {{else}} + accept={{@passThru.accept}} + autocomplete={{@passThru.autocomplete}} + autocorrect={{@passThru.autocorrect}} + autocapitalize={{@passThru.autocapitalize}} + autosave={{@passThru.autosave}} + form={{@passThru.form}} + formaction={{@passThru.formaction}} + formenctype={{@passThru.formenctype}} + formmethod={{@passThru.formmethod}} + formnovalidate={{@passThru.formnovalidate}} + formtarget={{@passThru.formtarget}} + height={{@passThru.height}} + inputmode={{@passThru.inputmode}} + min={{@passThru.min}} + maxlength={{@passThru.maxlength}} + max={{@passThru.max}} + multiple={{@passThru.multiple}} + name={{@passThru.name}} + pattern={{@passThru.pattern}} + readonly={{@passThru.readonly}} + required={{@passThru.required}} + selectionDirection={{@passThru.selectionDirection}} + size={{@passThru.size}} + spellcheck={{@passThru.spellcheck}} + step={{@passThru.step}} + tabindex={{@passThru.tabindex}} + title={{@title}} + width={{@passThru.width}}> {{/if}} -{{#unless hideAllMessages}} -
- {{#if maxlength}} +{{#unless this.hideAllMessages}} +
+ {{#if @maxlength}}
{{this.currentLength}}/{{@maxlength}}
{{/if}}
- {{#if isInvalidAndTouched}} -
- {{#each validationErrorMessages as |error index|}} -
+ {{#each @validationErrorMessages as |error index|}} +
{{error.message}} @@ -102,14 +102,14 @@ {{/unless}} {{yield (hash - charCount=currentLength - isInvalid=isInvalid - isTouched=isTouched - isInvalidAndTouched=isInvalidAndTouched - hasValue=hasValue - validationErrorMessages=validationErrorMessages + charCount=this.currentLength + isInvalid=this.isInvalid + isTouched=this.isTouched + isInvalidAndTouched=this.isInvalidAndTouched + hasValue=this.hasValue + validationErrorMessages=@validationErrorMessages )}} -{{#if iconRight}} - {{component iconComponent iconRight}} +{{#if @iconRight}} + {{component this.iconComponent @iconRight}} {{/if}} From cb920e5636a2f3a5ae6d63d3f85b0e12e5a84c17 Mon Sep 17 00:00:00 2001 From: Matthew Hartstonge Date: Fri, 4 Oct 2024 13:20:24 +1300 Subject: [PATCH 11/31] fix(addon/components/paper-item): remove no-implicit-this. --- addon/components/paper-item.hbs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/addon/components/paper-item.hbs b/addon/components/paper-item.hbs index 7e797cdc4..6b9458716 100644 --- a/addon/components/paper-item.hbs +++ b/addon/components/paper-item.hbs @@ -1,4 +1,4 @@ -{{! template-lint-disable no-action no-implicit-this }} +{{! template-lint-disable no-action }} {{#with (hash checkbox=(component "paper-checkbox" parentComponent=this bubbles=false shouldRegister=true) button=(component "paper-button" parentComponent=this bubbles=false shouldRegister=true skipProxy=true) @@ -6,9 +6,9 @@ radio=(component "paper-radio-proxiable" parentComponent=this bubbles=false shouldRegister=true) ) as |controls|}} - {{#if hasPrimaryAction}} + {{#if this.hasPrimaryAction}}
- +
{{yield controls}}
From 7acdf7dffc698f11e201d35f9c0f5330b82a49bd Mon Sep 17 00:00:00 2001 From: Matthew Hartstonge Date: Fri, 4 Oct 2024 13:23:27 +1300 Subject: [PATCH 12/31] fix(addon/components/paper-optgroup): remove no-implicit-this. --- addon/components/paper-optgroup.hbs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/addon/components/paper-optgroup.hbs b/addon/components/paper-optgroup.hbs index ed979e762..d55e314cb 100644 --- a/addon/components/paper-optgroup.hbs +++ b/addon/components/paper-optgroup.hbs @@ -1,3 +1,3 @@ -{{! template-lint-disable no-curly-component-invocation no-implicit-this }} - +{{! template-lint-disable no-curly-component-invocation }} + {{yield}} \ No newline at end of file From d856cc4684ea4f5b04a417193a895b2d389def82 Mon Sep 17 00:00:00 2001 From: Matthew Hartstonge Date: Fri, 4 Oct 2024 13:24:07 +1300 Subject: [PATCH 13/31] fix(addon/components/paper-radio-base): remove no-implicit-this. --- addon/components/paper-radio-base.hbs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/addon/components/paper-radio-base.hbs b/addon/components/paper-radio-base.hbs index 33a6751bf..46afc79ee 100644 --- a/addon/components/paper-radio-base.hbs +++ b/addon/components/paper-radio-base.hbs @@ -1,4 +1,4 @@ -{{! template-lint-disable no-curly-component-invocation no-implicit-this }} +{{! template-lint-disable no-curly-component-invocation }}
@@ -15,7 +15,7 @@ {{else}}
- {{label}} + {{@label}}
{{/if}} From e636dcbe6ba6f79f04daf26098fe319d6ad81624 Mon Sep 17 00:00:00 2001 From: Matthew Hartstonge Date: Fri, 4 Oct 2024 13:24:51 +1300 Subject: [PATCH 14/31] fix(addon/components/paper-radio-group-label): remove no-implicit-this. --- addon/components/paper-radio-group-label.hbs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/addon/components/paper-radio-group-label.hbs b/addon/components/paper-radio-group-label.hbs index c5de95f60..7dea1d339 100644 --- a/addon/components/paper-radio-group-label.hbs +++ b/addon/components/paper-radio-group-label.hbs @@ -1,7 +1,7 @@ -{{! template-lint-disable no-curly-component-invocation no-implicit-this }} +{{! template-lint-disable no-curly-component-invocation }} {{#if (has-block)}} {{yield}} {{else}} - {{text}} + {{@text}} {{/if}} From 3aad88404ee8fb33fdf78515cabb4983cfdb5815 Mon Sep 17 00:00:00 2001 From: Matthew Hartstonge Date: Fri, 4 Oct 2024 14:52:12 +1300 Subject: [PATCH 15/31] fix(addon/components/paper-radio-group): remove no-implicit-this. --- addon/components/paper-radio-group.hbs | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/addon/components/paper-radio-group.hbs b/addon/components/paper-radio-group.hbs index 7f6aada97..144663aa9 100644 --- a/addon/components/paper-radio-group.hbs +++ b/addon/components/paper-radio-group.hbs @@ -1,12 +1,12 @@ -{{! template-lint-disable no-action no-implicit-this }} +{{! template-lint-disable no-action }} {{yield (hash - label=(component labelComponent - setAriaLabelledby=(action (mut ariaLabelledby)) + label=(component this.labelComponent + setAriaLabelledby=(action (mut this.ariaLabelledby)) ) - radio=(component radioComponent - toggle=toggle - disabled=disabled - groupValue=groupValue + radio=(component this.radioComponent + toggle=@toggle + disabled=@disabled + groupValue=@groupValue onChange=(action "onChange") parentComponent=this shouldRegister=true) From 11c23bfd053222b4a6098750de6a5b7ff0ab64ab Mon Sep 17 00:00:00 2001 From: Matthew Hartstonge Date: Fri, 4 Oct 2024 15:03:11 +1300 Subject: [PATCH 16/31] fix(addon/components/paper-progress-circular): remove no-implicit-this. --- addon/components/paper-progress-circular.hbs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/addon/components/paper-progress-circular.hbs b/addon/components/paper-progress-circular.hbs index ba47b774e..1ea117beb 100644 --- a/addon/components/paper-progress-circular.hbs +++ b/addon/components/paper-progress-circular.hbs @@ -1,4 +1,3 @@ -{{! template-lint-disable no-implicit-this }} - - + + \ No newline at end of file From 7b180f13375a28c9f34acba3a08d29be612f7ccc Mon Sep 17 00:00:00 2001 From: Matthew Hartstonge Date: Fri, 4 Oct 2024 15:04:45 +1300 Subject: [PATCH 17/31] fix(addon/components/paper-progress-linear): remove no-implicit-this. --- addon/components/paper-progress-linear.hbs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/addon/components/paper-progress-linear.hbs b/addon/components/paper-progress-linear.hbs index 91bec9c31..29c14b4f4 100644 --- a/addon/components/paper-progress-linear.hbs +++ b/addon/components/paper-progress-linear.hbs @@ -1,6 +1,5 @@ -{{! template-lint-disable no-implicit-this }} -
+
-
-
+
+
From a7f77dd201e571c627b503f3a56032a8b088f1d0 Mon Sep 17 00:00:00 2001 From: Matthew Hartstonge Date: Fri, 4 Oct 2024 15:15:01 +1300 Subject: [PATCH 18/31] fix(addon/components/paper-sidenav): remove no-implicit-this. --- addon/components/paper-sidenav.hbs | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/addon/components/paper-sidenav.hbs b/addon/components/paper-sidenav.hbs index 9fafa7eff..0faf8335a 100644 --- a/addon/components/paper-sidenav.hbs +++ b/addon/components/paper-sidenav.hbs @@ -1,15 +1,15 @@ -{{! template-lint-disable no-action no-implicit-this }} -{{#unless closed}} +{{! template-lint-disable no-action }} +{{#unless this.closed}} {{/unless}} {{yield}} From cb52a348b1a41ea21ca98b3785147dcce8aeb4dd Mon Sep 17 00:00:00 2001 From: Matthew Hartstonge Date: Fri, 4 Oct 2024 15:25:48 +1300 Subject: [PATCH 19/31] fix(addon/components/paper-sidenav-toggle): remove no-implicit-this. --- addon/components/paper-sidenav-toggle.hbs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/addon/components/paper-sidenav-toggle.hbs b/addon/components/paper-sidenav-toggle.hbs index 788f02acb..ac354e36e 100644 --- a/addon/components/paper-sidenav-toggle.hbs +++ b/addon/components/paper-sidenav-toggle.hbs @@ -1,2 +1,2 @@ -{{! template-lint-disable no-action no-implicit-this }} -{{yield (action toggle)}} \ No newline at end of file +{{! template-lint-disable no-action }} +{{yield (action this.toggle)}} \ No newline at end of file From 98cfd7590e5471e5aca32bdc72a5c79cd41b1fdf Mon Sep 17 00:00:00 2001 From: Matthew Hartstonge Date: Fri, 4 Oct 2024 15:26:54 +1300 Subject: [PATCH 20/31] fix(addon/components/paper-speed-dial-actions): remove no-implicit-this. --- addon/components/paper-speed-dial-actions.hbs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/addon/components/paper-speed-dial-actions.hbs b/addon/components/paper-speed-dial-actions.hbs index 9df0043dc..9ce8dd959 100644 --- a/addon/components/paper-speed-dial-actions.hbs +++ b/addon/components/paper-speed-dial-actions.hbs @@ -1,4 +1,3 @@ -{{! template-lint-disable no-implicit-this }} {{yield (hash - action=(component "paper-speed-dial-actions-action" speedDial=speedDial) + action=(component "paper-speed-dial-actions-action" speedDial=@speedDial) )}} \ No newline at end of file From 3f44b05c7385ad2ca15bac8f2dec086a958f4f34 Mon Sep 17 00:00:00 2001 From: Matthew Hartstonge Date: Fri, 4 Oct 2024 15:27:47 +1300 Subject: [PATCH 21/31] fix(addon/components/paper-switch): remove no-implicit-this. --- addon/components/paper-switch.hbs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/addon/components/paper-switch.hbs b/addon/components/paper-switch.hbs index 52c4ebe32..461fc73e0 100644 --- a/addon/components/paper-switch.hbs +++ b/addon/components/paper-switch.hbs @@ -1,8 +1,8 @@ -{{! template-lint-disable no-curly-component-invocation no-implicit-this }} +{{! template-lint-disable no-curly-component-invocation }}
-
+
@@ -14,6 +14,6 @@
{{else}}
- {{label}} + {{@label}}
{{/if}} From 03aece8e332bbf254eb0c6d2a0496b5a9b7de68b Mon Sep 17 00:00:00 2001 From: Matthew Hartstonge Date: Fri, 4 Oct 2024 15:28:36 +1300 Subject: [PATCH 22/31] fix(addon/components/paper-tab): remove no-implicit-this. --- addon/components/paper-tab.hbs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/addon/components/paper-tab.hbs b/addon/components/paper-tab.hbs index 8021a2a57..f5007a8b9 100644 --- a/addon/components/paper-tab.hbs +++ b/addon/components/paper-tab.hbs @@ -1,7 +1,7 @@ -{{! template-lint-disable no-curly-component-invocation no-implicit-this }} +{{! template-lint-disable no-curly-component-invocation }} {{#if (has-block)}} {{yield}} {{else}} - {{name}} + {{@name}} {{/if}} \ No newline at end of file From 416b6efbfdf95f61ef64a7ad2b36a0fead2be073 Mon Sep 17 00:00:00 2001 From: Matthew Hartstonge Date: Fri, 4 Oct 2024 15:45:19 +1300 Subject: [PATCH 23/31] fix(addon/components/paper-tabs): remove no-implicit-this. --- addon/components/paper-tabs.hbs | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/addon/components/paper-tabs.hbs b/addon/components/paper-tabs.hbs index cf2d7c442..5df13b113 100644 --- a/addon/components/paper-tabs.hbs +++ b/addon/components/paper-tabs.hbs @@ -1,28 +1,28 @@ -{{! template-lint-disable no-action no-implicit-this }} - +{{! template-lint-disable no-action }} + - {{#if shouldPaginate}} - + {{#if this.shouldPaginate}} + {{paper-icon "keyboard-arrow-left"}} - + {{paper-icon "keyboard-arrow-left"}} {{/if}} - - + + {{yield (hash tab=(component "paper-tab" - noInk=noInk - selected=selected + noInk=this.noInk + selected=this.selected onSelect=(action "localOnChange") ) )}} - {{#if inkBar}} - + {{#if this.inkBar}} + {{/if}} From 62f3b8ace1d744b818c1a28b5923a5e99cef3cd8 Mon Sep 17 00:00:00 2001 From: Matthew Hartstonge Date: Fri, 4 Oct 2024 15:50:58 +1300 Subject: [PATCH 24/31] fix(addon/components/paper-toast): remove no-implicit-this. --- addon/components/paper-toast.hbs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/addon/components/paper-toast.hbs b/addon/components/paper-toast.hbs index f6ab59c44..8c9bd9208 100644 --- a/addon/components/paper-toast.hbs +++ b/addon/components/paper-toast.hbs @@ -1,6 +1,5 @@ -{{! template-lint-disable no-implicit-this }} -{{#in-element destinationEl insertBefore=null}} - +{{#in-element this.destinationEl insertBefore=null}} + {{yield (hash text=(component "paper-toast-text") )}} From 238a8b28f28f11ac7190739d3029e585566de019 Mon Sep 17 00:00:00 2001 From: Matthew Hartstonge Date: Fri, 4 Oct 2024 15:54:32 +1300 Subject: [PATCH 25/31] fix(addon/components/paper-input): validationErrorMessages are included via the ValidationMixin. --- addon/components/paper-input.hbs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/addon/components/paper-input.hbs b/addon/components/paper-input.hbs index 5ae43792e..11aea7be8 100644 --- a/addon/components/paper-input.hbs +++ b/addon/components/paper-input.hbs @@ -90,7 +90,7 @@
{{#if this.isInvalidAndTouched}}
- {{#each @validationErrorMessages as |error index|}} + {{#each this.validationErrorMessages as |error index|}}
@@ -107,7 +107,7 @@ isTouched=this.isTouched isInvalidAndTouched=this.isInvalidAndTouched hasValue=this.hasValue - validationErrorMessages=@validationErrorMessages + validationErrorMessages=this.validationErrorMessages )}} {{#if @iconRight}} From b139987267506af95d93cf79ebc6a430c07ce5fd Mon Sep 17 00:00:00 2001 From: Matthew Hartstonge Date: Fri, 4 Oct 2024 16:09:09 +1300 Subject: [PATCH 26/31] fix(addon/components/paper-radio-group): toggle and disabled are provided via the FocusableMixin. --- addon/components/paper-radio-group.hbs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/addon/components/paper-radio-group.hbs b/addon/components/paper-radio-group.hbs index 144663aa9..0d700809c 100644 --- a/addon/components/paper-radio-group.hbs +++ b/addon/components/paper-radio-group.hbs @@ -4,8 +4,8 @@ setAriaLabelledby=(action (mut this.ariaLabelledby)) ) radio=(component this.radioComponent - toggle=@toggle - disabled=@disabled + toggle=this.toggle + disabled=this.disabled groupValue=@groupValue onChange=(action "onChange") parentComponent=this From 35bc26fedcee1f8c998c488a4bcada8c034dc687 Mon Sep 17 00:00:00 2001 From: Matthew Hartstonge Date: Fri, 4 Oct 2024 16:16:05 +1300 Subject: [PATCH 27/31] fix(addon/components/paper-input): disabled is provided via the FocusableMixin. --- addon/components/paper-input.hbs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/addon/components/paper-input.hbs b/addon/components/paper-input.hbs index 11aea7be8..2041b50bd 100644 --- a/addon/components/paper-input.hbs +++ b/addon/components/paper-input.hbs @@ -12,7 +12,7 @@ class="md-input {{if this.isInvalid "ng-invalid"}} {{if this.isTouched "ng-dirty"}}" id={{this.inputElementId}} placeholder={{if this.shouldAddPlaceholder @placeholder}} - disabled={{@disabled}} + disabled={{this.disabled}} autofocus={{this.autofocus}} aria-describedby={{concat this.elementId "-char-count " this.elementId "-error-messages"}} onfocus={{@onFocus}} @@ -42,7 +42,7 @@ id={{this.inputElementId}} placeholder={{if this.shouldAddPlaceholder @placeholder}} type={{this.type}} - disabled={{@disabled}} + disabled={{this.disabled}} autofocus={{this.autofocus}} aria-describedby={{concat this.elementId "-char-count " this.elementId "-error-messages"}} onfocus={{@onFocus}} From 059d832795d3769c2fd859bc18187f4332ac118b Mon Sep 17 00:00:00 2001 From: Matthew Hartstonge Date: Fri, 4 Oct 2024 16:23:00 +1300 Subject: [PATCH 28/31] fix(addon/components/paper-toaster): remove no-implicit-this. --- addon/components/paper-toaster.hbs | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/addon/components/paper-toaster.hbs b/addon/components/paper-toaster.hbs index b32cce8e1..411208f71 100644 --- a/addon/components/paper-toaster.hbs +++ b/addon/components/paper-toaster.hbs @@ -1,14 +1,14 @@ -{{! template-lint-disable no-action no-curly-component-invocation no-implicit-this }} +{{! template-lint-disable no-action no-curly-component-invocation }} {{yield}} -{{#if activeToast.show}} - - {{#if activeToast.componentName}} - {{component activeToast.componentName}} +{{#if this.activeToast.show}} + + {{#if this.activeToast.componentName}} + {{component this.activeToast.componentName}} {{else}} - {{activeToast.text}} - {{#if activeToast.action}} - - {{activeToast.action.label}} + {{this.activeToast.text}} + {{#if this.activeToast.action}} + + {{this.activeToast.action.label}} {{/if}} {{/if}} From 394ef5d75d83160c36f8d4ee0c21772b2c047ddb Mon Sep 17 00:00:00 2001 From: Matthew Hartstonge Date: Fri, 4 Oct 2024 16:27:08 +1300 Subject: [PATCH 29/31] fix(addon/components/paper-tooltip): remove no-implicit-this. --- addon/components/paper-tooltip.hbs | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/addon/components/paper-tooltip.hbs b/addon/components/paper-tooltip.hbs index 624fdba56..c05c6cfb0 100644 --- a/addon/components/paper-tooltip.hbs +++ b/addon/components/paper-tooltip.hbs @@ -1,8 +1,7 @@ -{{! template-lint-disable no-implicit-this }} -{{#if renderTooltip}} - {{#in-element destinationEl insertBefore=null}} -
- +{{#if this.renderTooltip}} + {{#in-element this.destinationEl insertBefore=null}} +
+ {{yield}}
From 80ea59551ba52e713419157ace2170f978dafc82 Mon Sep 17 00:00:00 2001 From: Matthew Hartstonge Date: Fri, 4 Oct 2024 16:47:15 +1300 Subject: [PATCH 30/31] fix(dummy/app/templates/components/doc-content): remove no-implicit-this. --- tests/dummy/app/templates/components/doc-content.hbs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/dummy/app/templates/components/doc-content.hbs b/tests/dummy/app/templates/components/doc-content.hbs index 5c9ce3e98..05b0c455e 100644 --- a/tests/dummy/app/templates/components/doc-content.hbs +++ b/tests/dummy/app/templates/components/doc-content.hbs @@ -1,6 +1,5 @@ -{{! template-lint-disable no-implicit-this }} -
+
{{yield}}
\ No newline at end of file From 1328c7c1f2eaabdead508ed767683455d9bcb5a4 Mon Sep 17 00:00:00 2001 From: Matthew Hartstonge Date: Fri, 4 Oct 2024 17:00:21 +1300 Subject: [PATCH 31/31] fix(dummy/app/templates): remove no-implicit-this. --- tests/dummy/app/templates/application.hbs | 80 +++++++++---------- .../app/templates/components/example-item.hbs | 4 +- .../app/templates/components/menu-item.hbs | 5 +- .../app/templates/components/not-found.hbs | 4 +- .../app/templates/components/page-toolbar.hbs | 10 +-- .../app/templates/components/paper-api.hbs | 12 +-- .../app/templates/components/submenu-item.hbs | 3 +- .../dummy/app/templates/demo/autocomplete.hbs | 46 +++++------ tests/dummy/app/templates/demo/checkbox.hbs | 22 ++--- tests/dummy/app/templates/demo/chips.hbs | 16 ++-- tests/dummy/app/templates/demo/dialog.hbs | 30 +++---- tests/dummy/app/templates/demo/divider.hbs | 12 +-- tests/dummy/app/templates/demo/grid-list.hbs | 5 +- tests/dummy/app/templates/demo/input.hbs | 64 +++++++-------- tests/dummy/app/templates/demo/list.hbs | 28 +++---- tests/dummy/app/templates/demo/menu.hbs | 30 +++---- .../app/templates/demo/progress-circular.hbs | 22 ++--- .../app/templates/demo/progress-linear.hbs | 7 +- tests/dummy/app/templates/demo/radio.hbs | 14 ++-- tests/dummy/app/templates/demo/select.hbs | 24 +++--- tests/dummy/app/templates/demo/sidenav.hbs | 20 ++--- tests/dummy/app/templates/demo/slider.hbs | 36 ++++----- tests/dummy/app/templates/demo/speed-dial.hbs | 36 ++++----- tests/dummy/app/templates/demo/switch.hbs | 16 ++-- tests/dummy/app/templates/demo/tabs.hbs | 34 ++++---- tests/dummy/app/templates/demo/toast.hbs | 32 ++++---- tests/dummy/app/templates/demo/tooltip.hbs | 16 ++-- tests/dummy/app/templates/forms.hbs | 14 ++-- .../app/templates/layout/child-alignment.hbs | 14 ++-- .../app/templates/layout/introduction.hbs | 14 ++-- tests/dummy/app/templates/theme.hbs | 10 +-- 31 files changed, 338 insertions(+), 342 deletions(-) diff --git a/tests/dummy/app/templates/application.hbs b/tests/dummy/app/templates/application.hbs index 2a2824e95..ee405d002 100644 --- a/tests/dummy/app/templates/application.hbs +++ b/tests/dummy/app/templates/application.hbs @@ -1,6 +1,6 @@ -{{! template-lint-disable no-action no-implicit-this }} +{{! template-lint-disable no-action }} - +