Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-Language Issue #10

Open
rmatherly opened this issue May 2, 2014 · 1 comment
Open

Multi-Language Issue #10

rmatherly opened this issue May 2, 2014 · 1 comment

Comments

@rmatherly
Copy link

We have a site that has 6 language versions. We found that when the site was accessed with a context language other than English, the mobile detection did not work. This is because the GetRulesDevice method uses the context language, but the Device items only have English versions. In other languages, no devices are returned and the mobile detection fails. I was able to fix this by updating the GetRulesDevice method to change the Context.Language to English before retrieving the device list and change it back to whatever it was afterward.

I created a Fork with my changes: https://github.com/rmatherly/Sitecore-Mobile-Device-Detector. There may be a way to improve on this or make it configurable, but it solved the issue for me, so I wanted to share it.

@HaikoF
Copy link

HaikoF commented Apr 21, 2015

This should be no problem when you change the "Conditions" field to "shared" - by default it isn't, and this is imho the bug...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants