Save As Fragment #1433

dmaurya929 · 2024-10-03T15:28:16Z

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes and the overall coverage did not decrease.
All unit tests pass on CircleCi.
I ran all tests locally and they pass.

…nd panelcontainer

into saveAsFragment

into saveAsFragment-1

codecov · 2024-10-14T09:07:11Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.27%. Comparing base (19da0c7) to head (a855a8f).
Report is 3 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff            @@
##                dev    #1433   +/-   ##
=========================================
  Coverage     82.27%   82.27%           
  Complexity      923      923           
=========================================
  Files           103      103           
  Lines          2369     2369           
  Branches        321      321           
=========================================
  Hits           1949     1949           
  Misses          257      257           
  Partials        163      163

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

adobe-bot · 2024-10-15T05:31:40Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-10-15T05:34:51Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

rismehta

check comments

rismehta · 2024-10-15T09:48:36Z

...in/content/jcr_root/apps/forms-components-examples/components/form/fragment/_cq_template.xml

@@ -2,4 +2,5 @@
 <jcr:root xmlns:jcr="http://www.jcp.org/jcr/1.0" xmlns:nt="http://www.jcp.org/jcr/nt/1.0" xmlns:cq="http://www.day.com/jcr/cq/1.0"
    jcr:primaryType="nt:unstructured"
    jcr:title="Fragment"
+    fragmentPath=""


Why do we need an empty key here ?

We need a way to distinguish between a panel and a fragment component. So, we changed the component's cq: template to always include fragmentPath. Otherwise we will have to create new property like fd:viewType to differentiate

I would prefer fd:viewType rather than fragmentPath, since this is not intuitive.

rismehta · 2024-10-15T09:50:40Z

.../content/jcr_root/apps/core/fd/components/af-commons/v1/clientlibs/editor/utils/datamodel.js

+    window.CQ.FormsCoreComponents.Utils = window.CQ.FormsCoreComponents.Utils || {};
+    const DataModel = window.CQ.FormsCoreComponents.Utils.DataModel = window.CQ.FormsCoreComponents.Utils.DataModel || {};
+
+    var FORM_CONTAINER_SELECTOR = "[data-cmp-is='adaptiveFormContainer']";


None of this code is going to be changed by core component developers, let's move this code to cq-guides (like we have done for replace / rule editor etc), since this logic is very specific

Yes, these codes should not require any customization. In that case Data Model code will also required to moved to avoid duplicacy right ?

Yes, I agree that the data model code shouldn't be included here. We should keep the codebase clean by only including the relevant components that are customizable or useful for developers

rismehta · 2024-10-15T09:54:23Z

.../core/fd/components/form/panelcontainer/v1/panelcontainer/saveasfragment_dialog/.content.xml

+            </templateselector>
+            <fragmentselectcontainer
+                jcr:primaryType="nt:unstructured"
+                granite:class="coral-Form-fieldwrapper cmp-adaptiveform-saveasfragment__fragmentselector-container"


Why do you need this class, coral-Form-fieldwrapper

Just to align with style of other field wrapper in dialog . This field is appended on client side while others are rendered at server.
[1]: https://developer.adobe.com/experience-manager/reference-materials/6-5/coral-ui/coralui3/styles.html#coral-Form

.../core/fd/components/form/panelcontainer/v1/panelcontainer/saveasfragment_dialog/.content.xml

...e/fd/components/form/panelcontainer/v1/panelcontainer/clientlibs/editor/js/saveasfragment.js

into saveAsFragment-1

...pps/core/fd/components/form/container/v2/container/clientlibs/editorhook/js/fragmentshook.js

...in/content/jcr_root/apps/forms-components-examples/components/form/fragment/_cq_template.xml

.../content/jcr_root/apps/core/fd/components/af-commons/v1/clientlibs/editor/utils/datamodel.js

…side

rismehta

check comments

.../content/jcr_root/apps/core/fd/components/af-commons/v1/clientlibs/editor/utils/datamodel.js

...ps/core/fd/components/form/container/v2/container/clientlibs/editorhook/js/componentutils.js

rismehta · 2024-11-29T08:45:28Z

...ps/core/fd/components/form/container/v2/container/clientlibs/editorhook/js/componentutils.js

@@ -171,4 +174,34 @@

    window.CQ.FormsCoreComponents.editorhooks.allowedCompFieldTypes = [];

+    window.CQ.FormsCoreComponents.editorhooks.getFormContainerProperties =  (editablePath) => {
+        const result = $.ajax({


Can we use the new fetch syntax here, rather than using $.ajax

Ajax call is made with async: false, used in condition 1 to display DOR action in the editable toolbar. Since fetch is inherently asynchronous, it'll require adding support in the core editor to handle async/await so keeping as it is.

.../content/jcr_root/apps/core/fd/components/af-commons/v1/clientlibs/editor/utils/datamodel.js

rismehta

check comments

TalmizAhmed and others added 16 commits April 27, 2023 14:54

Save As Fragment button in authoring accordion, tabs on top, wizard a…

d942347

…nd panelcontainer

Merge branch 'dev' into saveAsFragment

da5bc6b

Authoring tests

9e3f782

Fix crashing of cypress

59516ad

Changes from comments

0722eb7

Dialog name change

5668a5f

Merge branch 'fragment' into saveAsFragment

e8e4118

Merge branch 'fragment' into saveAsFragment

2779112

API data object

f998f9c

Minor changes to dialog content.xml

27a05aa

Merge branch 'fragment' into saveAsFragment

f07043b

Reverting dor hook change

2be1d13

Merge branch 'dev' of https://github.com/adobe/aem-core-forms-components

87bd533

into saveAsFragment

FORMS-16112 Save as fragment

2437bc4

Merge branch 'dev' of https://github.com/adobe/aem-core-forms-components

a7d97f3

into saveAsFragment-1

FORMS-16112 Save panel as fragment support

a855a8f

dmaurya929 added 2 commits October 15, 2024 10:37

FORMS-16112 fix validation and tests

6340fbc

FORMS-16112 fix validation and tests

7b961c6

rismehta requested changes Oct 15, 2024

View reviewed changes

dmaurya929 added 2 commits October 29, 2024 09:31

FORMS-16112 moving code

2eb8d6a

Merge branch 'dev' of https://github.com/adobe/aem-core-forms-components

aa04649

into saveAsFragment-1

rismehta reviewed Nov 8, 2024

View reviewed changes

...pps/core/fd/components/form/container/v2/container/clientlibs/editorhook/js/fragmentshook.js Show resolved Hide resolved

rismehta reviewed Nov 8, 2024

View reviewed changes

...in/content/jcr_root/apps/forms-components-examples/components/form/fragment/_cq_template.xml Show resolved Hide resolved

rismehta reviewed Nov 8, 2024

View reviewed changes

.../content/jcr_root/apps/core/fd/components/af-commons/v1/clientlibs/editor/utils/datamodel.js Show resolved Hide resolved

dmaurya929 added 2 commits November 13, 2024 11:45

FORMS-16112 review comment and move fragment template code to server-…

6c0614f

…side

FORMS-17206 review comment

e03180e

rismehta requested changes Nov 29, 2024

View reviewed changes

FORMS-16112 review comment

38139df

rismehta reviewed Dec 3, 2024

View reviewed changes

.../content/jcr_root/apps/core/fd/components/af-commons/v1/clientlibs/editor/utils/datamodel.js Show resolved Hide resolved

rismehta requested changes Dec 3, 2024

View reviewed changes

FORMS-16112 review comment

751e5e1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Save As Fragment #1433

Save As Fragment #1433

dmaurya929 commented Oct 3, 2024

codecov bot commented Oct 14, 2024

adobe-bot commented Oct 15, 2024

adobe-bot commented Oct 15, 2024

rismehta left a comment

rismehta Oct 15, 2024

dmaurya929 Oct 15, 2024

rismehta Oct 15, 2024

rismehta Oct 15, 2024

dmaurya929 Oct 15, 2024

rismehta Nov 8, 2024

rismehta Oct 15, 2024

dmaurya929 Oct 15, 2024

rismehta left a comment

rismehta Nov 29, 2024

dmaurya929 Dec 2, 2024

rismehta left a comment

Save As Fragment #1433

Are you sure you want to change the base?

Save As Fragment #1433

Conversation

dmaurya929 commented Oct 3, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

codecov bot commented Oct 14, 2024

Codecov Report

adobe-bot commented Oct 15, 2024

Accessibility Violations Found

adobe-bot commented Oct 15, 2024

Accessibility Violations Found

rismehta left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rismehta left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rismehta left a comment

Choose a reason for hiding this comment