Update AFDKO submodule to version 3.7.1 #26
Conversation
|
thanks. If cmake is now a build requirement of afdko, perhaps we could add it to the pyproject.toml build system's |
|
maybe try to set CIBW_BUILD_VERBOSITY=1 to debug why the build is failing? https://cibuildwheel.readthedocs.io/en/stable/options/#build-verbosity |
dscorbett
force-pushed
the
afdko-3.7.1
branch
from
b170933
to
03e6db7
Compare
|
The log said: so adding |
|
@josh-hadley can you please add @dscorbett as external contributor to the repo? I can't seem to be able to do it in the settings. Otherwise Github doesn't automatically run the CI checks when he pushes new commits and waits for me to click "approve" each time. |
|
strange, it's attempting to build cmake wheel from source instead of using one of the pre-compiled wheels (https://pypi.org/project/cmake/#files). This shouldn't happen... |
dscorbett
force-pushed
the
afdko-3.7.1
branch
from
03e6db7
to
331c85e
Compare
|
The manylinux1 image uses glibc 2.5, so I added the suggested version specifier suggested in the latest build log: |
|
it now failed at the configure step for antlr with maybe you should try thanks a lot for taking care of this! |
dscorbett
force-pushed
the
afdko-3.7.1
branch
from
331c85e
to
31d4448
Compare
|
If this fails again, could you manually rerun the non-Linux builds, which are aborted when the Linux one fails? Once the Linux build works, we may have similar problems on macOS and Windows, and it would be more efficient to debug them all in parallel. |
|
maybe try to add |
|
have a look at https://github.com/adobe-type-tools/afdko/blob/21d8b26f6caa930c29c187c9f8b201d67cf4de0d/.github/workflows/build_wheels.yml#L62 I think we should mimic afdko's upsteram CI setup to make sure it builds, since theirs seems to work |
dscorbett
force-pushed
the
afdko-3.7.1
branch
from
31d4448
to
237cf43
Compare
|
I compared this repo’s build_wheels.yml to https://github.com/adobe-type-tools/afdko/blob/3.7.1/.github/workflows/build_wheels.yml and it was very similar, except |
|
still failing.. once a first PR is merged for a first-time contributor, subsequent ones will not require this annoying manual approval after each commit.. |
dscorbett
force-pushed
the
afdko-3.7.1
branch
from
237cf43
to
174f81e
Compare
dscorbett
force-pushed
the
afdko-3.7.1
branch
7 times, most recently
from
84a5c78
to
5feb02c
Compare
|
The latest workflow passed. I downloaded the artifact and verified that the manylinux and macOS universal wheels don’t have the original bug about three-byte integers. |
.github/workflows/build_wheels.yml
Outdated
| # skip PyPy (no manylinux1), 32-bit linux, musl linux, and other architectures | ||
| CIBW_SKIP: "pp* cp*manylinux_i686 cp*manylinux_aarch64 cp*manylinux_ppc64le cp*manylinux_s390x *-musllinux*" | ||
| # skip PyPy (no manylinux2014), 32-bit linux, musl linux, and other architectures | ||
| CIBW_SKIP: "pp* cp*manylinux_i686 cp*manylinux_aarch64 cp*manylinux_ppc64le cp*manylinux_s390x cp*win32 *-musllinux*" |
There was a problem hiding this comment.
Why skip win32? Isn't it still the default python3 download on python.org?
There was a problem hiding this comment.
AFDKO’s build_wheels.yml skips it. I don’t know why. I restored it and the workflow still passed.
pyproject.toml
Outdated
| @@ -1,5 +1,6 @@ | |||
| [build-system] | |||
| requires = [ | |||
| "cmake<3.23", | |||
There was a problem hiding this comment.
I think we can remove the version specifier here since we're now using more up to date manylinux image
dscorbett
force-pushed
the
afdko-3.7.1
branch
from
5feb02c
to
ed2c94d
Compare
|
Thank you! |
This fixes #22. I updated it only to 3.7.1, instead of to the latest version, because 3.7.1 is the last version to support Python 3.6, which cffsubr still supports.