Skip to content
This repository has been archived by the owner on Sep 15, 2023. It is now read-only.

Removed PDF to bitmap scaling #216

Closed
wants to merge 1 commit into from
Closed

Removed PDF to bitmap scaling #216

wants to merge 1 commit into from

Conversation

mabe-at
Copy link

@mabe-at mabe-at commented Jul 27, 2021

When PDF is scaled up during bitmap rendering, the QR code position markers are sometimes warped which results in 'NO_CODE_FOUND'.

Fixes #203

@goebelUB
Copy link
Contributor

goebelUB commented Aug 4, 2021

Thanks for pointing this out!

We've including this in #234, making an Austrian test cert that we have work.
Fun fact: fixing the DPI/density conversion to use floats and round later makes the same cert work as well.
Finally, we still have another cert whose PDF-derived bitmap is not recognised by zxing, so I won't close #203 just yet.

@goebelUB goebelUB closed this Aug 4, 2021
@mabe-at
Copy link
Author

mabe-at commented Aug 24, 2021

It's not country specific.

Would you like to share that NCF-PDF, if it's possible?

Kind regards.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import of Covid Certificate via App is failing
2 participants