Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A possible discrepancy in PUT Statements doc #1104

Open
raouldj opened this issue Jun 27, 2022 · 6 comments
Open

A possible discrepancy in PUT Statements doc #1104

raouldj opened this issue Jun 27, 2022 · 6 comments

Comments

@raouldj
Copy link

raouldj commented Jun 27, 2022

In https://github.com/adlnet/xAPI-Spec/blob/master/xAPI-Communication.md#stmtres "2.1.1 PUT Statements" under the "Details" it is said that the PUT endpoint "Stores a single Statement with the given id." However the last item in the "LRS Requirements" states following: "If the LRS receives a batch of Statements containing two or more Statements with the same id, it SHOULD* reject the batch and return 400 Bad Request.".

This seems to be a copy paste error from "2.1.2 POST Statements" since the PUT statements endpoint should not be able to handle batches of statements as stated under the "Details".

@thomasturrell
Copy link
Contributor

@andyjohnson what is the process for pull requests for the xAPI spec?

I believe that this is a legitimate issue.

@andyjohnson
Copy link
Contributor

Thanks for your keen eyes, everyone. We did catch this as we transition to the IEEE and effectively xAPI 2.0. This process has taken much longer than anticipated, but it will be an open standard and shared from this GitHub once publicly available.

@erickr
Copy link

erickr commented Aug 19, 2022

@andyjohnson Is there any publicly available summary of what the scope of changes are for the xAPI 2.0 on a technical level?

@andyjohnson
Copy link
Contributor

andyjohnson commented Aug 19, 2022 via email

@scherrey
Copy link

scherrey commented Aug 3, 2023

Just noticed this issue today when my team was asking me about how to implement PUT with multiple statements. My first reaction was that this doesn't seem to jive with PUT semantics at all so I'm glad I'm not the only one who feels this way. It's been a year since last comment on this item. Have IEEE xAPI 2.x efforts kicked off and, if so, how can one get involved?

@brianjmiller
Copy link
Contributor

1.03 -> 2.0.0 Change Log can be found at https://opensource.ieee.org/xapi/xapi-base-standard-documentation/-/blob/main/ChangeLog.md

xAPI 2.0 is now an IEEE standard. Any continuing work is done through LTSC committee working groups, with the base standard being the important one for the xAPI standard itself: https://sagroups.ieee.org/9274-1-1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants