You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
describe('An LRS\'s Statement Resource upon processing a successful POST request returns code 200 OK and all Statement UUIDs within the POST **Implicit** (Communication 2.1.2.s1, XAPI-00146)',function(){
The tests should be duplicated and tests with payloads of:
Single statement as an array
Multiple statements as an array
The text was updated successfully, but these errors were encountered:
I saw the GitHub notification over the weekend and initially ignored it tbh, thinking "this is probably the most common use case for an LRS, there's absolutely no way it's not being tested".
Surprisingly, we can't find a statement array payload test anywhere, making this quite the oversight. 😬
Introducing a new test atm would be a little awkward with the 2.0.0 changes rolling out sometime over the next few months, so I am going to suggest we introduce this into the 2.0.0 branch soon and update the 1.0.3 suite during the 2.0.0 release -- as folks will already be re-testing their LRS's.
I'll look over the style and whatnot to make sure everything jives with the existing setup and then hopefully get this into 2.0.0 soon-ish.
The Spec here:
https://github.com/adlnet/xAPI-Spec/blob/master/xAPI-Communication.md#212-post-statements
States the statement resource should accept "An array of Statements or a single Statement to be stored."
The tests only test a single statement payload:
XAPI-00147 -
lrs-conformance-test-suite/test/v1_0_3/H.Communication2.1-StatementResource.js
Line 246 in 14778f9
XAPI-00146 -
lrs-conformance-test-suite/test/v1_0_3/H.Communication2.1-StatementResource.js
Line 265 in 14778f9
The tests should be duplicated and tests with payloads of:
The text was updated successfully, but these errors were encountered: