Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test for LRS rejecting statement because of missing choices | scale | source | target | steps property #241

Open
garemoko opened this issue Nov 7, 2018 · 1 comment
Open

test for LRS rejecting statement because of missing choices | scale | source | target | steps property #241

garemoko opened this issue Nov 7, 2018 · 1 comment
Assignees
@vbhayden

Comments

@garemoko
Copy link

garemoko commented Nov 7, 2018 •
edited
Loading

We had an issue where our LRS was incorrectly rejecting statements that had an interactionType, but did not have any corresponsing 'choices | scale | source | target | steps' property. Since these are optional properties, we shouldn't have been rejecting them.

Would be good to include a test for this.
@vbhayden
Copy link
Member

vbhayden commented Nov 7, 2018

Agree, this seems like an oversight.

@vbhayden vbhayden self-assigned this Nov 7, 2018
@vbhayden vbhayden mentioned this issue Nov 7, 2018
Merged
@vbhayden vbhayden mentioned this issue Mar 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vbhayden vbhayden

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garemoko @vbhayden