Issue with LTS test packages 201-1 through 201-4

[cawerkenthin]

There are two errors in the xml file.
a) The au IRI is invalid.
b) The url is invalid as it is a relative path that is not part of a zip package.

I don't think this is a good test of the LMS import. The LMS may reject the package for one reason or the other, so it is not a good test of the IRI validation.

[brianjmiller]

These are intentionally invalid packages intended to confirm that the LMS rejects the package. See the comment, example at:

https://github.com/adlnet/CATAPULT/blob/main/lts/pkg/src/201-1-iris-course-id.xml#L18

[brianjmiller]

Ah, I see what you are saying, if the order of the checks is reversed then it could be for the other reason, but either way it has to be rejected which is really the pertinent thing to test. Why it is rejected is irrelevant from a conformance standpoint, it might be better from a usability of the test suite for specifically debugging an invalid LMS to improve that, but that's subjective.

[cawerkenthin]

I believe the purpose of these particular packages was to valid the IRI checking of the LMS. The inclusion of a relative paths in a non-zipped package is checked elsewhere (in other packages). Thus it is not necessary to have 2 errors in a single package.

[thomasturrell]

Thus it is not necessary to have 2 errors in a single package.

I agree. A test should fail for one reason.