Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support units of variable types. #26

Open
ZGainsforth opened this issue Sep 22, 2022 · 1 comment
Open

Support units of variable types. #26

ZGainsforth opened this issue Sep 22, 2022 · 1 comment

Comments

@ZGainsforth
Copy link
Collaborator

One option for supporting units is to apply astropy's unit module. When initiating the JANAF (or burcat, or other db) there can be an optional parameter to add units to returned values. Then an if statement on the output would add units only if this optional flag is set to true. It would default to false to provide backward compatibility. Thoughts?

@adelq
Copy link
Owner

adelq commented Oct 29, 2022

I think that's a good idea more generally to ensure that units are being used in a consistent way. I would rather use a unit library that has fewer dependencies than astropy though given the limited overlap, maybe something like pint or something similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants