feat(cli): Add --filename-template and --max-length options #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces two new CLI arguments to allow fine-grained control over how output file paths are generated:
--filename-template: Specify a template string using variables like {domain}, {hash}, {ext} to define a custom directory structure and file naming scheme
--max-length: Set a maximum character limit for generated file paths, intelligently truncating if needed while preserving essential components
Includes documentation updates covering the new options, examples, and troubleshooting.
Closes adbar#754
|
That will be great. I am looking forward for this feature to make it to this incredible tool. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #763 +/- ##
==========================================
- Coverage 99.26% 99.03% -0.24%
==========================================
Files 21 22 +1
Lines 3559 3728 +169
==========================================
+ Hits 3533 3692 +159
- Misses 26 36 +10 ☔ View full report in Codecov by Sentry. |
|
@AdamQuadmon Thanks for the substantial PR, it's great that you included tests and documentation. Could you please make sure the tests pass for older Python versions? I don't think the code security warning are important. |
|
Please also improve test coverage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces two new CLI arguments to allow fine-grained control over how output file paths are generated:
--filename-template: Specify a template string using variables like {domain}, {hash}, {ext} to define a custom directory structure and file naming scheme
--max-length: Set a maximum character limit for generated file paths, intelligently truncating if needed while preserving essential components
Includes documentation and tests.
Closes #754