Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add article to bg-color mixin (fix #539) #540

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented Dec 18, 2024

Fixes #539

Fix

  • Adds article to the bg-color mixin

Testing

  1. Add a bg-color class to an article
  2. Add displayTitle, body, and instruction values to the article

Expected behaviour

Text colors should be changed in the article header text

@swashbuck swashbuck self-assigned this Dec 18, 2024
@guywillis
Copy link
Contributor

Hey @swashbuck,

Adding .article to the mixin will allow background colour application to the article but the associated title / body etc styles won't apply to the child blocks and articles, necessitating further classes on lower levels.

Is this behaviour as expected?

@swashbuck
Copy link
Contributor Author

Adding .article to the mixin will allow background colour application to the article but the associated title / body etc styles won't apply to the child blocks and articles, necessitating further classes on lower levels.

@guywillis Actually, I think it would, but you can still override it on child elements.

For instance, here I have a bg-color only on the article. The component inherits the colors.

If I add a bg-color to the component, then I can override the colors:

Is this an unintended side effect?

@guywillis
Copy link
Contributor

I believe I have made a mistake and misunderstood what impact.

It appears, and confirming through testing, as though adding an article class to the mixin works as required.

Please disregard the comments in my previous message.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs Reviewing
Development

Successfully merging this pull request may close these issues.

Include articles in bg-color mixin
3 participants