-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: Adapt buttons overhaul (fixes #469) #490
Open
guywillis
wants to merge
87
commits into
master
Choose a base branch
from
issue/469
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- focus state inherits from hover (as per existing component focus styles) - existing @visited vars are only used by components so grouped with content item
- focus state inherits from hover (as per existing focus styles) - locked state inherits from disabled (as per existing locked styles)
- Replace @btn-ui-color vars with @ui-color vars. Nav, Notify and Drawer btns inherit from their view colours. This sets an extra level of vars to define global ui colors or edit these separately as per existing Vanilla. - rename _buttonStates.less file to _state-mixins.less.
- ui-btn-controls vars added - shared Notify and Drawer btn styles combined into single ui-btn--controls mixin. Replacing .notify-btn-icon mixin.
- set menu item btn vars to inherit from item ui
- item ui locked state added - set .narrative__strapline-icon to inherit from narrative__strapline-btn to reduce additional state declaration styles
… controls and strapline - Narrative strapline icon background color set to transparent to prevent icon background obscuring the btn focus outline
- border-radius added - default drawer item vars represent current drawer styles - margin gives option to display items in a 'button style' - when margin is set, apply border to whole of button (not just bottom)
- drawer item selected state expanded to support aria-current="true" (used by languagepicker which should inherit selected, not disabled styling.
- share border-width variable between drawer and notify UI button controls - remove reference to 'color' from border width variables - change reference from 'icon' to 'btn' for nav ui border-width variable for consistency with other nav btn spacing variables - move border-width variables into spacing less - set menu item to inherit its own border-radius variable
…nt breaking change
…vent breaking change
…acy support only - prevent breaking change - @nav-icon-locked and @nav-icon-disabled color vars added
transparent buttons could be problematic accessibility wise
- align focus and selected styles with 'master' - remove 'outline' box-shadow in favour of border. Border is used to visually distinguish/separate each item whilst box-shadow is stylistic only
...file doesn't include states or mixins
kirsty-hames
changed the title
Breaking: Adapt buttons overhaul (fixes #469)
New: Adapt buttons overhaul (fixes #469)
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #469
New
Note
The following has been implemented to prevent any breaking changes:
.notify-btn-icon
mixin left in for legacy support only (with comments). New.ui-btn-ctrl
provided as fallback for backwards compatibilty..btn-text
and.btn-icon
selectors for legacy support only (with comments).To Do
Summary