Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inview animations not triggered on page load #588

Closed
swashbuck opened this issue Oct 9, 2024 · 0 comments · Fixed by #589
Closed

inview animations not triggered on page load #588

swashbuck opened this issue Oct 9, 2024 · 0 comments · Fixed by #589
Labels
bug Something isn't working

Comments

@swashbuck
Copy link
Contributor

swashbuck commented Oct 9, 2024

Subject of the issue

When a page first loads, inview animations are not triggered until the user starts to scroll down the page.

Relates to:
#579

Your environment

  • FW 5.41.3
  • Core 6.56.0
  • Mac Firefox / Chrome

Steps to reproduce

Make the following changes to the Vanilla course that is created from adapt create course. These steps are not necessary but assist with reproducing the issue.

  1. co-100: Add hide-page-header to _htmlClasses
  2. b-100 and b-105: Use _onScreen animations with _percentInviewVertical set to 1
  3. Vanilla theme: In _less/_defaults/animations.less, set @animation-delay to 0s
  4. View the co-100 page

Expected behaviour

Blocks should immediately animate in.

Actual behaviour

Blocks do not animate until you start scrolling down the page.

Screen recording

Oct-09-2024.12-53-47.mp4
@swashbuck swashbuck added the bug Something isn't working label Oct 9, 2024
@oliverfoster oliverfoster moved this from New to Needs Reviewing in adapt_framework: The TODO Board Oct 10, 2024
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Oct 14, 2024
github-actions bot pushed a commit that referenced this issue Oct 14, 2024
## [6.57.1](v6.57.0...v6.57.1) (2024-10-14)

### Fix

* Inview locking and triggering (fixes #588) (#589) ([84e673e](84e673e)), closes [#588](#588) [#589](#589)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant