Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not report a score as never incorrect #102

Closed
oliverfoster opened this issue Sep 19, 2023 · 1 comment · Fixed by #103
Closed

Do not report a score as never incorrect #102

oliverfoster opened this issue Sep 19, 2023 · 1 comment · Fixed by #103
Assignees
@oliverfoster
Labels
bug released

Comments

@oliverfoster
Copy link
Member

oliverfoster commented Sep 19, 2023 •
edited
Loading

Subject of the issue

This question cannot be answered incorrectly and so should not contribute to maxScore or score as its score will be constant regardless of the answer.

Override:
https://github.com/adaptlearning/adapt-contrib-core/blob/7f467b257c4232e3bd1641c4adda4cd261639b4d/js/models/questionModel.js#L147-L192
https://github.com/adaptlearning/adapt-contrib-slider/blob/873b93f4a60f3b2f036cd2b42db7e2862f364568/js/SliderModel.js#L127-L146
@oliverfoster oliverfoster self-assigned this Sep 19, 2023
@oliverfoster oliverfoster moved this from New to Needs Reviewing in adapt_framework: The TODO Board Sep 19, 2023
oliverfoster added a commit that referenced this issue Sep 19, 2023
@oliverfoster
Fix: Report no score or maxScore (fixes #102)
1993c5c
@oliverfoster oliverfoster mentioned this issue Sep 19, 2023
Merged
joe-allen-89 pushed a commit that referenced this issue Oct 13, 2023
@oliverfoster
Fix: Report no score or maxScore, is always correct and never partly …
a46c856 
…correct (fixes #102) (#103)

* Fix: Report no score or maxScore (fixes #102)

* Added defaults for correctness

* Update ConfidenceSliderModel.js

* Update ConfidenceSliderModel.js
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Oct 13, 2023
github-actions bot pushed a commit that referenced this issue Oct 13, 2023
@semantic-release-bot
Chore(release): 5.4.7 [skip ci]
7d9f02f 
## [5.4.7](v5.4.6...v5.4.7) (2023-10-13)

### Fix

* Report no score or maxScore, is always correct and never partly correct (fixes #102) (#103) ([a46c856](a46c856)), closes [#102](#102) [#103](#103) [#102](#102)
@github-actions
Copy link

🎉 This issue has been resolved in version 5.4.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverfoster oliverfoster

Labels
bug released
Projects
None yet
Milestone
No milestone
1 participant
@oliverfoster