Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module assumes 1-based tracking IDs #7

Closed
chris-steele opened this issue Oct 16, 2024 · 1 comment
Closed

Module assumes 1-based tracking IDs #7

chris-steele opened this issue Oct 16, 2024 · 1 comment
Assignees
Labels
bug An error has occurred

Comments

@chris-steele
Copy link
Contributor

What happened?

The framework uses 0-based tracking IDs: https://github.com/adaptlearning/adapt_framework/blob/master/grunt/helpers/data/Language.js#L239

This module will identify a block with _trackingId:0 as having no ID due to this line: https://github.com/adapt-security/adapt-authoring-spoortracking/blob/master/lib/SpoorTrackingModule.js#L33 and subsequently convert it to _trackingId:1. This will cause a runtime error if there is another block which already has _trackingId:1

Expected behaviour

No response

Steps to reproduce

See above

Authoring tool version

master

Framework version

master

What browsers are you seeing the problem on?

No response

Relevant log output

No response

@chris-steele chris-steele added the bug An error has occurred label Oct 16, 2024
@chris-steele chris-steele self-assigned this Oct 16, 2024
@chris-steele chris-steele changed the title Module uses 1-based tracking IDs Module assumes 1-based tracking IDs Oct 16, 2024
@chris-steele
Copy link
Contributor Author

Fixed in 71dcf07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error has occurred
Projects
Development

No branches or pull requests

1 participant