Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fields to be excluded from automatic typing #13

Open
chris-steele opened this issue Sep 25, 2024 · 1 comment
Open

Allow fields to be excluded from automatic typing #13

chris-steele opened this issue Sep 25, 2024 · 1 comment
Labels
enhancement New or additional functionality high priority Should be prioritised over all other issues

Comments

@chris-steele
Copy link
Contributor

chris-steele commented Sep 25, 2024

Feature description

On insert/update data will be parsed for strings that match ObjectIds. This is not always desirable, for example _friendlyId is defined as a string by its schema not an ObjectId. Is there a way to work around this?

This also leads to a question: should this module be mutating data at all given that the function of validation/sanitisation is handled by jsonschema?

@chris-steele chris-steele added the enhancement New or additional functionality label Sep 25, 2024
@chris-steele chris-steele added the high priority Should be prioritised over all other issues label Sep 26, 2024
@taylortom
Copy link
Collaborator

The reason we have parsing for ObjectId strings is that mongo simply will not work with a combination of strings & ObjectIds - the DB operations will not work as expected.

Why do we not want _friendlyIds to be parsed as ObjectIds?

@taylortom taylortom moved this from New to Backlog in adapt-authoring: The TODO Board Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New or additional functionality high priority Should be prioritised over all other issues
Projects
Development

No branches or pull requests

2 participants