Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post CRUD hooks should be awaited #16

Closed
chris-steele opened this issue Oct 11, 2024 · 1 comment
Closed

Post CRUD hooks should be awaited #16

chris-steele opened this issue Oct 11, 2024 · 1 comment
Assignees
Labels
bug An error has occurred

Comments

@chris-steele
Copy link
Contributor

What happened?

The code awaits the outcome of the pre- hooks, but not the post- hooks. I think it would be useful/safe not to respond to the request until the post- hooks have completed. This way clients would have an accurate way of determining when the operation has completed (e.g. when determining when to show and hide a loading popup).

Expected behaviour

See above

Steps to reproduce

N/A

Authoring tool version

v1

Framework version

No response

What browsers are you seeing the problem on?

No response

Relevant log output

No response

@taylortom
Copy link
Collaborator

Yep, sounds reasonable to me

@taylortom taylortom moved this from Backlog to Assigned in adapt-authoring: The TODO Board Oct 14, 2024
@taylortom taylortom changed the title await post hooks Post CRUD hooks should be awaited Oct 14, 2024
@github-project-automation github-project-automation bot moved this from Assigned to Merged in adapt-authoring: The TODO Board Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error has occurred
Projects
Development

No branches or pull requests

2 participants