Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent using mutable parts of the action object #2

Open
adambiltcliffe opened this issue Dec 28, 2019 · 0 comments
Open

Prevent using mutable parts of the action object #2

adambiltcliffe opened this issue Dec 28, 2019 · 0 comments

Comments

@adambiltcliffe
Copy link
Owner

In development mode, we should find a way to protect the user from passing in an object that contains e.g. an array and then returning that array as part of the state, because it will not be frozen like the rest of the state. (Example: if it's modified during the playAction call, then board-state will use the modified version when testing replayability, which produces very misleading errors.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant