Skip to content
This repository has been archived by the owner on May 2, 2023. It is now read-only.

Transform bug fixes, typos that break. #32

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/netsuite_toolkit.js
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@ NetsuiteToolkit.getLineItemCount = function(record, sublist_name) {
* @memberof NetsuiteToolkit
* @return {number} The value of the filed on the given sublist at the given index
*/
NetsuiteToolkit.getLineItemValue = function(record, sublist_name, index, field_name) {
return record.getLineItemValue(sublist_name, index, field_name);
NetsuiteToolkit.getLineItemValue = function(record, sublist_name, field_name, index) {
return record.getLineItemValue(sublist_name, field_name, index);
}

/**
Expand Down Expand Up @@ -473,7 +473,7 @@ NetsuiteToolkit.SublistProcessor = (function() {
*/
SublistProcessor.prototype.compareLineItemValue = function(index, match_field, match_value) {
netsuite_value = NetsuiteToolkit.getLineItemValue(this.record, this.sublist_name,
index, match_field);
match_field, index);
return (netsuite_value == match_value);
}

Expand Down
6 changes: 5 additions & 1 deletion lib/transform.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
var no_internalid_given_error = "No internal id was supplied, cannot source " +
"record for transformation";
var type_not_lower_case = "Transform record types must be all lower case.";

/**
* Transformer Class
Expand Down Expand Up @@ -103,6 +104,8 @@ this.TransformRequest = (function() {
*/
TransformRequest.prototype.execute = function() {
if(!this.internalid) { throw TransformRequest.NoInternalIdGiven; }
if(this.source_type !== this.source_type.toLowerCase() ||
this.result_type !== this.result_type.toLowerCase()){ throw TransformRequest.TypeNotLowerCase; }

this.record = NetsuiteToolkit.transformRecord(this.source_type, this.internalid,
this.result_type, this.transform_values);
Expand Down Expand Up @@ -154,6 +157,7 @@ this.TransformRequest = (function() {
})();

this.TransformRequest.NoInternalIdGiven = new Error(no_internalid_given_error);
this.TransformRequest.TypeNotLowerCase = new Error(type_not_lower_case);

/** @namespace global */

Expand All @@ -167,6 +171,6 @@ this.TransformRequest.NoInternalIdGiven = new Error(no_internalid_given_error);
*/
var transformPostHandler = function(request) {
transformer = new Transformer(request);
transformer.transformRecord();
transformer.transformRecords();
return transformer.generateReply();
}