[WIP] ♻️ (typescript) convert TransactionListWithBalances.jsx to .tsx #3876
Conversation
cindywu
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
cindywu
changed the title
| @@ -314,16 +315,20 @@ function TransactionListWithPreviews({ | |||
| ); | |||
|
|
|||
| const transactionsToDisplay = !isSearching | |||
| ? previewTransactions.concat(transactions) | |||
There was a problem hiding this comment.
The original code was resulting in a readonly version of transactions.
There was a problem hiding this comment.
That is intentional. We should instead update transactions prop of TransactionListWithBalances as readonly
| marginTop: 10, | ||
| }} | ||
| > | ||
| <> |
There was a problem hiding this comment.
The only change here is I wrapped the two children in a <></> so that there is only a single child inside <SelectedProvider></SelectedProvider>. I did not touch the components inside the <></>
|
This is probably ready for review, but let me do one more pass tomorrow. |
| @@ -247,9 +248,9 @@ function TransactionListWithPreviews({ | |||
| const dispatch = useDispatch(); | |||
| const navigate = useNavigate(); | |||
|
|
|||
| const onRefresh = useCallback(() => { | |||
| const onRefresh = useCallback(async () => { | |||
There was a problem hiding this comment.
Why does this need to be async?
| @@ -314,16 +315,20 @@ function TransactionListWithPreviews({ | |||
| ); | |||
|
|
|||
| const transactionsToDisplay = !isSearching | |||
| ? previewTransactions.concat(transactions) | |||
There was a problem hiding this comment.
That is intentional. We should instead update transactions prop of TransactionListWithBalances as readonly
| @@ -57,6 +66,19 @@ function TransactionSearchInput({ placeholder, onSearch }) { | |||
| ); | |||
| } | |||
|
|
|||
| type TransactionListWithBalancesProps = { | |||
| isLoading: boolean | undefined; | |||
There was a problem hiding this comment.
| isLoading: boolean | undefined; | |
| isLoading?: boolean; |
| @@ -57,6 +66,19 @@ function TransactionSearchInput({ placeholder, onSearch }) { | |||
| ); | |||
| } | |||
|
|
|||
| type TransactionListWithBalancesProps = { | |||
| isLoading: boolean | undefined; | |||
| transactions: TransactionEntity[]; | |||
There was a problem hiding this comment.
| transactions: TransactionEntity[]; | |
| transactions: readonly TransactionEntity[]; |
| balanceCleared, | ||
| balance, | ||
| }: { | ||
| balanceUncleared: SheetFields<SheetNames>; |
There was a problem hiding this comment.
Please make a BalanceWithClearedProps type
| @@ -170,7 +202,7 @@ function BalanceWithCleared({ balanceUncleared, balanceCleared, balance }) { | |||
| ); | |||
| } | |||
|
|
|||
| function Balance({ balance }) { | |||
| function Balance({ balance }: { balance: SheetFields<SheetNames> }) { | |||
There was a problem hiding this comment.
Please make a BalanceProps
| balanceUncleared={balanceQueries.uncleared} | ||
| balance={balanceQueries.balance.name as SheetFields<SheetNames>} | ||
| balanceCleared={ | ||
| (balanceQueries.cleared?.name as SheetFields<SheetNames>) ?? undefined |
There was a problem hiding this comment.
This will change the behavior. This is ignoring the query property of the binding. These should be Bindings instead.
|
👋 Hi! It looks like this PR has not had any changes for a week now. Would you like someone to review this PR? If so - please remove the "[WIP]" prefix from the PR title. That will let the community know that this PR is open for a review. |
|
This PR was closed because it has been stalled for 5 days with no activity. |
#1483
CategoryTransactions.jsxto .tsxAccountTransactions.tsx