Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Amount of upcoming entry with split categories is doubled in the running balance #3897

Open
2 tasks done
atopley opened this issue Nov 25, 2024 · 5 comments
Open
2 tasks done
Labels
bug Something isn't working

Comments

@atopley
Copy link

atopley commented Nov 25, 2024

Verified issue does not already exist?

  • I have searched and found no existing issue
  • I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

When viewing the running balance on an account, if an upcoming entry is showing from the Schedule, but has not yet been posted, and it has a rule to split the transaction into multiple categories, the split amounts are added to the total transaction amount when calculating the running balance (e.g. a transaction with total value £300 would change the running balance by £600).

Recreatable as follows:

  1. Enable "Show running balances" on an account
  2. Create a scheduled against that account that is due within 7 days (or within the period specified under the experimental feature "Scheduled transaction upcoming length adjustment")
  3. In the schedule click "Edit as rule"
  4. Click "Split into multiple categories" and add 2 or more splits then save the rule
  5. Check the running balance against the upcoming transaction

A demo budget files showing the issue is attached
2024-11-25-My Finances 1.zip

Where are you hosting Actual?

Pikapods

What browsers are you seeing the problem on?

Microsoft Edge

Operating System

Windows 11

@atopley atopley added the bug Something isn't working label Nov 25, 2024
@joel-jeremy
Copy link
Contributor

I've done some work on the running balance on this PR: #3708. Can you please try the demo link on the PR to see if the issue still persists?

@atopley
Copy link
Author

atopley commented Nov 27, 2024

Thanks Joel, unfortunately the issue still exists in PR: #3708. See example screenshot, transaction with split categories and total value 1,000 reduces the running balance by 2,000:

image

@joel-jeremy
Copy link
Contributor

@atopley Can you check now? I've pushed some updates. Thanks!

@joel-jeremy
Copy link
Contributor

By the way, this is related to #3508

@atopley
Copy link
Author

atopley commented Nov 28, 2024

Hi Joel, your updates appear to have fixed the issue, thanks! Apologies for missing #3508 - I did do a search before submitting the issue, so I'm not sure how I missed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants