Menu Option Disappears Completely On Certain Screen Size #3880
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
ericji1326
changed the title
|
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
packages/desktop-client/src/components/accounts/Header.tsxOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-eslint-plugin". (The package "eslint-plugin-eslint-plugin" was not found when loaded as a Node module from the directory "/packages/eslint-plugin-actual".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-eslint-plugin" was referenced from the config file in "packages/eslint-plugin-actual/.eslintrc.js". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. WalkthroughThe pull request introduces changes to the Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
packages/desktop-client/index.html (1)
112-114: Consider a more targeted CSS reset approach.While
all: unsetwill solve the immediate issue, it might be more maintainable to identify and reset only the specific properties causing the menu visibility problem (e.g., opacity, visibility, display, etc.)..view-reset { - all: unset; + /* Reset only specific properties */ + opacity: 1 !important; + visibility: visible !important; + display: flex !important; + position: static !important; }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
upcoming-release-notes/3880.mdis excluded by!**/*.md
📒 Files selected for processing (2)
packages/desktop-client/index.html(1 hunks)packages/desktop-client/src/components/accounts/Header.tsx(3 hunks)
✅ Files skipped from review due to trivial changes (1)
- packages/desktop-client/src/components/accounts/Header.tsx
🔇 Additional comments (1)
packages/desktop-client/index.html (1)
112-114: LGTM! Verify across all affected screen sizes.
The addition of .view-reset with all: unset should help resolve the menu visibility issue by removing inherited styles that may be causing the problem.
✅ Verification successful
The view-reset class is appropriately used to fix menu visibility
The verification shows that the view-reset class is correctly implemented in Header.tsx specifically around the MenuButton components, which aligns with fixing the menu dropdown visibility issue. The class is applied in three menu-related contexts within the account header, making it a targeted solution rather than an overly aggressive reset.
- Applied to account menu view containers in
packages/desktop-client/src/components/accounts/Header.tsx - Properly defined in
packages/desktop-client/index.htmlwithall: unset
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Find all components using the new view-reset class to ensure proper application
rg -l "view-reset" --type tsx --type jsx
Length of output: 68
Script:
#!/bin/bash
# Search for view-reset class usage in all files, including HTML, CSS, and JavaScript/TypeScript
rg "view-reset" -l
# Also check for any CSS files specifically
fd -e css -e scss
Length of output: 232
Script:
#!/bin/bash
# Let's see how the view-reset class is being used in Header.tsx
rg "view-reset" packages/desktop-client/src/components/accounts/Header.tsx -B 2 -A 2
# Also check the context in index.html to understand the full implementation
rg "view-reset" packages/desktop-client/index.html -B 2 -A 2
Length of output: 618
I'll get a fix up ASAP |
|
Hey @jfdoming, I have made the change as you requested! Let me know what you think! 😄 |
There was a problem hiding this comment.
Thanks! Looks good. If you have time, would be nice to add a screenshot test for this—you can follow this template. Otherwise happy to merge as is
Hey @jfdoming! Thanks for the PR approval! I think I'm pretty low on time due to exams. May I get this just merged as is? Thanks! |
Fixes #3850