🐛 fix condition "notes contains (nothing)" throwing error (#3943)

actualbudget · Dec 9, 2024 · a289227 · a289227
1 parent d649eec
commit a289227
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/packages/loot-core/src/server/accounts/transaction-rules.ts b/packages/loot-core/src/server/accounts/transaction-rules.ts
@@ -291,7 +291,11 @@ export async function runRules(trans) {
   return await finalizeTransactionForRules(finalTrans);
 }
 
-function conditionSpecialCases(cond: Condition): Condition {
+function conditionSpecialCases(cond: Condition | null): Condition | null {
+  if (!cond) {
+    return cond;
+  }
+
   //special cases that require multiple conditions
   if (cond.op === 'is' && cond.field === 'category' && cond.value === null) {
     return new Condition(

diff --git a/upcoming-release-notes/3943.md b/upcoming-release-notes/3943.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [MatissJanis]
+---
+
+Fix rule creation throwing error for "notes contains (nothing)" condition.