Page/Component Object refactor; Added new tests for Landing/Home/Sign-in pages #997
Conversation
…n, sidebar-left, navigation
Thank you for the pull request!The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
✅ Deploy Preview for activist-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
aasimsyed
changed the title
|
Lemme know when this is ready for a final review, @aasimsyed :) Would be good to do a call this week as well, if it can work on your end 😊 |
|
Sorry for the wait on this, @aasimsyed! I'll write you on Matrix as well, but let me know if you'd like to do a call to fix the frontend checks, run the most recent version of the Playwright tests and then bring this in :) CC @cquinn540 who expressed interest in looking into the tests a bit. Maybe the three of us can do a call? |
|
One note on this is that the |
| return (await this.page.locator("html").getAttribute("class")) ?? ""; | ||
| } | ||
|
|
||
| public getLocator(selector: keyof typeof this.locators): Locator { |
There was a problem hiding this comment.
Is there a reason we don't want to use locators the way Playwright recommends? https://playwright.dev/docs/locators
getLocator discourages that, and also encourages us to use ids to locate most of our elements as opposed to using roles and labels the way a user would.
|
Hey @aasimsyed 👋 Let me know if a call over the weekend to bring this in would work on your end, or if not when'd be a good time :) Hope you're well! |
Contributor checklist
Description
updated Playwright
ignored tests/results/reports from watch
added an html reporter for axe
updated components and pages with id locators for use in tests
refactored the page object model design, updated page/component objects, tests for landing, home, and sign-in pages
added a utility method to run accessibility tests on any given page
tested locally
Related issue
N/A