Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Payment Method ('ashleyplcc') Not Recognized After PR #1253 Merge #1271

Open
vurtnec opened this issue Dec 20, 2024 · 0 comments
Open

New Payment Method ('ashleyplcc') Not Recognized After PR #1253 Merge #1271

vurtnec opened this issue Dec 20, 2024 · 0 comments

Comments

@vurtnec
Copy link

vurtnec commented Dec 20, 2024

Issue Description

I have submitted a PR as per the repository’s contribution guidelines: #1253, and it has already been merged into the main branch.

However, when deploying my Shopify app after 3 weeks ago, I encounter the following error:

supported_payment_methods: Following payment methods ["ashleyplcc"] not permitted.
image

It seems that although the code changes have been merged, they have not yet been deployed, as my Shopify app deployment cannot recognize the newly added payment method ('ashleyplcc').

Steps to Reproduce

  1. Add ashleyplcc in supported_payment_methods in shopify.extension.toml
  2. Deploy the app to Shopify.
  3. Observe the deployment error.

Expected Behavior

After the PR is merged into the main branch, the new payment method ashleyplcc should be available during Shopify app deployment and show icon in my store checkout page.

Actual Behavior

The Shopify app deployment fails with an error indicating that the ashleyplcc payment method is not permitted.

Reference

Could someone please confirm whether the latest changes have been deployed and advise if there is any additional action I need to take?

@vurtnec vurtnec changed the title https://github.com/activemerchant/payment_icons/pull/1253/files New Payment Method ('ashleyplcc') Not Recognized After PR #1253 Merge Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant