Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

labelbox integration #2995

Merged
merged 58 commits into from
Dec 12, 2024
Merged

labelbox integration #2995

merged 58 commits into from
Dec 12, 2024

Conversation

tyesayan
Copy link

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Things to be aware of

Things to worry about

Additional Context

@tyesayan tyesayan requested a review from activesoull November 22, 2024 14:28
@CLAassistant
Copy link

CLAassistant commented Nov 22, 2024 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 5 committers have signed the CLA.

✅ tyesayan
✅ artgish
✅ activesoull
❌ zaaram
❌ Tigran Yesayan

Tigran Yesayan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@tyesayan tyesayan requested a review from khustup2 November 22, 2024 16:33
khustup2
khustup2 reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor

@khustup2 khustup2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the dependency on labelbox optional. If not, any way we can make it optional?

@tyesayan
Copy link
Author

tyesayan commented Nov 25, 2024 •
edited
Loading

Is the dependency on labelbox optional. If not, any way we can make it optional?

@khustup2 I think it is, as far as I understand this makes it optional, but I might be wrong.
cc @levongh

@tyesayan tyesayan marked this pull request as ready for review November 25, 2024 19:39
@tyesayan tyesayan changed the title wip labelbox integration labelbox integration Nov 25, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 11.26187% with 654 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...eplake/integrations/labelbox/labelbox_converter.py 10.59% 194 Missing ⚠️
deeplake/integrations/labelbox/v3_converters.py 6.17% 167 Missing ⚠️
deeplake/integrations/labelbox/labelbox_utils.py 16.26% 103 Missing ⚠️
deeplake/integrations/labelbox/labelbox_.py 13.63% 76 Missing ⚠️
deeplake/integrations/labelbox/labelbox_debug.py 0.00% 57 Missing ⚠️
...e/integrations/labelbox/labelbox_metadata_utils.py 20.31% 51 Missing ⚠️
...lake/integrations/labelbox/labelbox_azure_utils.py 25.00% 6 Missing ⚠️

📢 Thoughts on this report? Let us know!

tyesayan and others added 27 commits December 3, 2024 18:03
@tyesayan
add fail_on_labelbox_project_export_error argument to skip labelbox e…
6ee3bbe 
…xport failures
@tyesayan
Merge branch 'v3' of https://github.com/activeloopai/deeplake into v3…
3dca0a9 
…-labelbox-integration
@tyesayan
fix assertion failure in labelbox integration while parsing segments
e8b5e95
@tyesayan
add metadata support in labelbox integration
a143b4e
@tyesayan
fix labelbox values interpolation
edf0e54
@tyesayan
add duplication check for create_labelbox_annotation_project
669e26f
@tyesayan
fix duplicate label addition for checkboxes during interpolation
88b548b
@tyesayan
update connect to labelbox test
60e2426
@tyesayan
reformat labelbox integration files
f29fceb
@tyesayan
fix labelbox_utils mypy errors
f30b95b
@tyesayan
update labelbox integration test
e3cec14
@tyesayan
fix labelbox integration test
e70faac
@tyesayan
Merge branch 'v3' of https://github.com/activeloopai/deeplake into v3…
b68d910 
…-labelbox-integration
@tyesayan
fix mypy lint error
1719be5
@zaaram
Trigger Action
c15d447
@tyesayan
add labelbox azure utils test
bb18a99
@tyesayan
Merge branch 'v3-labelbox-integration' of https://github.com/activelo…
560d4b9 
…opai/deeplake into v3-labelbox-integration
@tyesayan
cleanup labelbox debug classes
d7a6ed2
@tyesayan
reformat labelbox ingestion files
b5b2f23
@activesoull
fixed darglint
937b2d9
@activesoull
Merge branch 'v3-labelbox-integration' of github.com:activeloopai/dee…
06dde0c 
…plake into v3-labelbox-integration
@activesoull
fixed darglint
dd3557b
@tyesayan
use labelbox export_v2 instead of export
519b357
@tyesayan
update error log for labelbox project export
7b38832
@tyesayan
skip test_connect_to_labelbox
b13f582
@tyesayan
reformat test_labelbox.py
1a2acc0
@tyesayan
skip test_labelbox_azure_utils
90839e0
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 11, 2024

Quality Gate Passed Quality Gate passed

Issues
50 New issues
0 Accepted issues

Measures
0 Security Hotspots
11.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@activesoull activesoull merged commit fb7ef6b into v3 Dec 12, 2024
9 of 11 checks passed
@activesoull activesoull deleted the v3-labelbox-integration branch December 12, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khustup2 khustup2 khustup2 left review comments

@activesoull activesoull activesoull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tyesayan @CLAassistant @activesoull @khustup2 @artgish @zaaram