Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

realignMap does not give an error when there are insufficient points in common #119

Open
drserajames opened this issue Mar 20, 2022 · 0 comments

Comments

@drserajames
Copy link
Member

procrustesMap gives an error if there are two few points in common between the two maps. realignMap does not give any error or warning.

My ideal behaviour would be an error, similar to the one for procrustesMap.

Low priority to fix for me; I should just stop trying to align maps that have one point in common.

> packageVersion("Racmacs")
[1] ‘1.1.35’
> set.seed(850909)
> dat <- matrix(10*2^round(10*runif(100)), ncol=10)
> map <- make.acmap(dat)
Performing 100 optimizations
============================================================================================================
Optimization runs complete
Took 0.04 secs

> 
> map1 <- removeAntigens(map, 6:10)
> map1 <- removeSera(map1, 6:10)
> 
> map2 <- removeAntigens(map, 1:4)
> map2 <- removeSera(map2, 1:5)
> 
> procrustesMap(map1, map2)
Error: Not enough matching points (1)
> realignMap(map1,map2)
<acmap>

...5 antigens
...5 sera
...100 optimizations
> map1 <- removeAntigens(map, 6:10)
> map1 <- removeSera(map1, 6:10)
> 
> map2 <- removeAntigens(map, 1:5)
> map2 <- removeSera(map2, 1:5)
> 
> procrustesMap(map1, map2)
Error: Not enough matching points (0)
> realignMap(map1,map2)
<acmap>

...5 antigens
...5 sera
...100 optimizations
map1 <- removeAntigens(map, 6:10)
map1 <- removeSera(map1, 6:10)

map2 <- removeAntigens(map, 1:3)
map2 <- removeSera(map2, 1:5)

procrustesMap(map1, map2)
realignMap(map1,map2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant