Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation of matching and merging - names & IDs #117

Open
drserajames opened this issue Mar 17, 2022 · 0 comments
Open

Documentation of matching and merging - names & IDs #117

drserajames opened this issue Mar 17, 2022 · 0 comments

Comments

@drserajames
Copy link
Member

mergeMaps(maps), match_mapAntigens(map1, map2) and match_mapSera(map1, map2) seem to match on IDs if present, and Names if not. mergeMaps(maps) documentation doesn't describe how the ag & sr are matched. match_mapAntigens(map1, map2) describes matching by name.

Another way to do this would be an additional attribute:agMergeIDs(map) and srMergeIDs(map). These would take the value of IDs if present and Names if not. But could also be set by the user, without over-writing the information in IDs. Or perhaps that's how you see the current IDs. And perhaps I need a srLabIDs(map) to keep the IDs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant