Added Director Nav Links #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
attach issue |
shahdivyank
reviewed
Nov 8, 2024
| @@ -0,0 +1,9 @@ | |||
| const Page = () => { | |||
There was a problem hiding this comment.
do not add the pages yet, just need the navigation
shahdivyank
reviewed
Nov 8, 2024
src/data/director/navigation.tsx
Outdated
| }, | ||
| { | ||
| name: "Applications", | ||
| link: "/director/:program/application", |
There was a problem hiding this comment.
if the link is dynamic, we should instead make each link a function which returns a string for the dynamically generated url
shahdivyank
reviewed
Nov 11, 2024
src/app/director/layout.tsx
Outdated
| const segments = pathname.split("/"); | ||
| const navigation = links.map(({ name, link }) => ({ | ||
| name, | ||
| link: link(segments[2], segments[4]), |
There was a problem hiding this comment.
what happens when segments 2 and 4 dont exist? there should be a fallback
shahdivyank
reviewed
Nov 11, 2024
src/data/director/navigation.tsx
Outdated
| }, | ||
| { | ||
| name: "Applications", | ||
| link: (program: string) => `/director/${program}/application`, |
There was a problem hiding this comment.
prolly want all the functions to be the same parameter wise so it gives less problems
gnite and uid123, also made it so that static link segments wont feed into dynamic links
shahdivyank
reviewed
Nov 19, 2024
src/app/director/layout.tsx
Outdated
| <div className="h-full"> | ||
| <Navigation links={links} /> | ||
| <div className="flex h-full"> | ||
| <Navigation links={navigation} /> |
There was a problem hiding this comment.
logic should be handled inside navigation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new routes and ignored the initial "director" section. I followed the routes on figma, but I was unsure if this was the correct route for the "directors" section
The Routes: src > data > director