TS migration #2
Open
TS migration #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mongoose to MongoDB Node.js Driver
shahdivyank
reviewed
Sep 23, 2024
src/app/api/user/route.ts
Outdated
|
|
||
| const { name, email }: User = await req.json(); | ||
| try { | ||
| const db = client.db(); |
There was a problem hiding this comment.
db config should be made in the util file
shahdivyank
reviewed
Sep 23, 2024
src/app/error.tsx
Outdated
| @@ -1,5 +1,7 @@ | |||
| "use client"; | |||
|
|
|||
| import React from "react"; | |||
There was a problem hiding this comment.
dont need react imports
shahdivyank
reviewed
Sep 23, 2024
src/app/layout.tsx
Outdated
| @@ -1,6 +1,7 @@ | |||
| /* eslint-disable new-cap */ | |||
| import "./globals.css"; | |||
| import { Inter } from "next/font/google"; | |||
| import React from "react"; | |||
There was a problem hiding this comment.
dont need react imports
shahdivyank
reviewed
Sep 23, 2024
src/app/layout.tsx
Outdated
| @@ -10,7 +11,11 @@ export const metadata = { | |||
| description: "MongoDB Setup Integration with Next.js", | |||
| }; | |||
|
|
|||
| export default function RootLayout({ children }) { | |||
| type Prop = { | |||
shahdivyank
reviewed
Sep 23, 2024
src/app/page.tsx
Outdated
| e.preventDefault(); | ||
| api({ | ||
| method: "POST", | ||
| url: "/api/user", | ||
| body: { name, email }, | ||
| }) | ||
| .then(() => toast(`Submitted successfully!`)) | ||
| .then((res) => { | ||
| if (res.status >= 200 && res.status < 300) { |
There was a problem hiding this comment.
range checks dont work with http 😭 u can assume that if it goes thru its alr good
There was a problem hiding this comment.
oh i never wrote that, i think that was an issue with dev branch
shahdivyank
reviewed
Sep 23, 2024
src/utils/api.ts
Outdated
| @@ -0,0 +1,25 @@ | |||
| type apiGet = { | |||
There was a problem hiding this comment.
should just be request or Request
shahdivyank
reviewed
Sep 23, 2024
src/utils/api.ts
Outdated
| body: object; | ||
| }; | ||
|
|
||
| type apiResponse = { |
There was a problem hiding this comment.
should just be Response or response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
had some issues with dev branch but should be good.