Migrate repo to TypeScript #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahdivyank
reviewed
Sep 15, 2024
src/app/layout.tsx
Outdated
| @@ -10,7 +10,11 @@ export const metadata = { | |||
| description: "Firebase Setup Integration with Next.js", | |||
| }; | |||
|
|
|||
| export default function RootLayout({ children }) { | |||
| type Props = { | |||
There was a problem hiding this comment.
- use interface
- lowercase props
shahdivyank
reviewed
Sep 15, 2024
src/utils/api.ts
Outdated
| @@ -0,0 +1,21 @@ | |||
| type Body = { | |||
There was a problem hiding this comment.
- interface
- all lowercase
shahdivyank
reviewed
Sep 15, 2024
src/utils/firebase.ts
Outdated
| @@ -1,7 +1,16 @@ | |||
| import { initializeApp } from "firebase/app"; | |||
| import { getFirestore } from "firebase/firestore"; | |||
|
|
|||
| const firebaseConfig = { | |||
| type Config = { | |||
There was a problem hiding this comment.
- interface
- lowercase
- check to see if firebase alr has a config type u can use
shahdivyank
reviewed
Sep 25, 2024
src/utils/api.ts
Outdated
| email: string; | ||
| } | ||
|
|
||
| interface apifunc { |
There was a problem hiding this comment.
should just be called request
shahdivyank
reviewed
Sep 25, 2024
src/utils/api.ts
Outdated
| @@ -0,0 +1,21 @@ | |||
| interface body { | |||
There was a problem hiding this comment.
body should be defined by some HTML/JS generated thing or not at all, this is a general API wrapper so we cant conform to just the name and email
shahdivyank
reviewed
Sep 25, 2024
tsconfig.json
Outdated
| "lib": ["dom", "dom.iterable", "esnext"], | ||
| "allowJs": true, | ||
| "skipLibCheck": true, | ||
| "strict": false, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.