combined components in course folder #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kye019
commented
Nov 4, 2024
kye019
commented
Closed
shahdivyank
reviewed
Nov 4, 2024
src/components/course/name.tsx
Outdated
| @@ -4,7 +4,7 @@ interface CourseNameProps { | |||
|
|
|||
| const Name = ({ children }: CourseNameProps) => { | |||
| return ( | |||
| <div className="font-Malayalam rounded-2xl bg-devstation-cyan-100 py-4 text-center text-6xl text-white"> | |||
| <div className="font-Malayalam w-[65vw] rounded-2xl bg-devstation-cyan-100 p-[2vw] text-center text-[4vw] text-white"> | |||
There was a problem hiding this comment.
can just use w-3/5 and padding shouldn't be 2vw
shahdivyank
reviewed
Nov 4, 2024
| @@ -1,6 +1,6 @@ | |||
| const ShortCourseDescription = () => { | |||
| return ( | |||
| <div className="mx-auto flex w-[90vw] flex-col items-center rounded-2xl bg-devstation-cyan-100 p-[5vw] text-center"> | |||
| <div className="mx-auto flex w-[75vw] flex-col items-center rounded-2xl bg-devstation-cyan-100 p-[5vw] text-center"> | |||
shahdivyank
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.