added home page graphics #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahdivyank
reviewed
Nov 4, 2024
src/app/page.tsx
Outdated
| <div className="absolute mt-[10%] text-white"> | ||
| <About /> | ||
| </div> | ||
| <div className="absolute ml-[8vw] mt-[200vh] w-1/4"> |
There was a problem hiding this comment.
shouldn't need 200vh here
shahdivyank
reviewed
Nov 4, 2024
src/app/page.tsx
Outdated
| import Landing from "@/components/home/Landing"; | ||
| import About from "@/components/home/about"; | ||
| import Projects from "@/components/home/Projects"; | ||
| import ProjectCard from "@/components/home/ProjectCard"; | ||
| import Cat from "@/public/images/randomCat.webp"; |
There was a problem hiding this comment.
use one of the existing images as a placeholder for now
Nsaleem1
added
help wanted
|
merge conflict |
shahdivyank
reviewed
Nov 4, 2024
src/app/page.tsx
Outdated
| <div className="absolute ml-[8vw] w-1/4"> | ||
| <ProjectCard | ||
| backgroundImage={HomePic} | ||
| title="Lorem Ipsum" |
There was a problem hiding this comment.
should come from data files, will make it easier when we need to plug and play
Nsaleem1
added
ready for review
and removed
help wanted
shahdivyank
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
projectsVid.mp4