feat (components): live-reveal #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Live Reveal component
✅ Deploy Preview for aclu-emails ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hellogoodbyte
changed the title
PaleBluDot
reviewed
Aug 28, 2023
There was a problem hiding this comment.
@hellogoodbyte it makes it much harder to do a QA when there is this extra code here. Please pull away the table component and save it in src/_includes/components/live-reveal.njk
There was a problem hiding this comment.
If there is a style tag make sure to save it withing the component. I will go in afterward when clearing up for mobile to clean all of that up.
There was a problem hiding this comment.
Once you do that, you can remove this file.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Live Reveal component