Marking Laser - Use laserTarget

[PabstMirror]

Rework #7761

Uses ace_laser system to handle getting origin and direction
eliminates the stair-step flicker of trying to manually sync turret direction
does require the laser to be on as well

[mrschick]

I've tested this a bit in SP, when lasing from a loitering UAV (Yabhon) at 1000m AGL, the beam will lag behind a POINT tracked target (relative to the direction of flight) by about 3-4m across the ground. From the POV of the UAV it looks fine.
This isn't really a critical issue though.

Could some flashing pattern be implemented? Afaik irl TGP laser pointers flash in a pattern to be more noticeable, especially from the air or when only the spot on the ground is really going to be visible.

[PabstMirror]

because it's scripted, it's pretty easy to add any patterns we want

IZLID lasers mentioned a 3-5Hz pulse, so I went with that

[mrschick]

Works pretty well, except for the spot being comically large at low TGP zoom levels in any illuminator mode.

It's an issue that I didn't get before in markinglaser, where the beam itself could be seen from a UAV's perspective.

I'm also not sure about the requirement of the LD having to be on to fire the illuminator.
LDs apparently use 1060nm (some modern ones 1550nm) light, which should be almost invisible to Gen3 tubes (page 2, "HyMa photocathode"), which would defeat the purpose of illumination for all NVG-equipped allies.

[PabstMirror]

https://www.youtube.com/watch?v=v1vLwu_oWLQ this is the problem with original markingLaser pr
the syncing became jerky with any movement of source
the LaserTarget marker seems to be updated by the engine fairly rapidly so it's easier to make smooth

[johnb432]

I know absolutely nothing about drawLaser, so please forgive my ignorance, but what was wrong with the old method of drawing it to max distance and adding onto it from there?

[johnb432]

Is there a reason why this needs to be executed after the CBA settings have been initialised?

[PabstMirror]

I wasn't sure what we wanted to do for settings on this
just threw it inside so it would be easy to add

[johnb432]

I'd update the XEH to make it uniform with the rest of ACE:

class Extended_InitPost_EventHandlers {
    class Air {
        class ADDON {
            init = QUOTE(_this call FUNC(onAircraftInit));
        };
    };
};

Otherwise, LGTM