Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Global Error Handler #4

Open
fsciuti opened this issue Nov 12, 2019 · 2 comments
Open

Add Global Error Handler #4

fsciuti opened this issue Nov 12, 2019 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@fsciuti
Copy link
Member

fsciuti commented Nov 12, 2019

Angular has a global error handling class called errorHandler that provides a hook for centralized exception handling inside your application.
We need to detect errors with a class inherited by errorHandler

@fsciuti fsciuti added enhancement New feature or request help wanted Extra attention is needed labels Nov 12, 2019
@fathorMB
Copy link

I could build a class named GlobalErrorHandler that inherits from ErrorHandler and set it up in the providers' configuration to get it working. Just one thing: how do you picture the user interaction with errors? Toast notifications? Browser alert? Just in console for development purposes?

@fsciuti
Copy link
Member Author

fsciuti commented Nov 12, 2019

Hi @fathorMB, we should implement a simple toast or snack bar (without Material or similar).
Anyway, a simple console log might be right for now!

fathorMB pushed a commit to fathorMB/redis-patterns-console that referenced this issue Nov 13, 2019
Add global error handler and set it as provider in main module

Could be a starting point for issue acadevmy#4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants