Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release a new version to hex.pm #293

Open
rmoorman opened this issue Sep 7, 2024 · 1 comment
Open

Release a new version to hex.pm #293

rmoorman opened this issue Sep 7, 2024 · 1 comment

Comments

@rmoorman
Copy link

rmoorman commented Sep 7, 2024

While running updates on an existing phoenix application that is using absinthe, I got the following compilation warning:

==> absinthe_plug
Compiling 18 files (.ex)
    warning: Application.get_env/2 is discouraged in the module body, use Application.compile_env/3 instead
    │
  5 │   @config Application.get_env(:absinthe_plug, Absinthe.Plug.GraphiQL)
    │                       ~
    │
    └─ lib/absinthe/plug/graphiql/assets.ex:5:23: Absinthe.Plug.GraphiQL.Assets (module)

Generated absinthe_plug app

When looking at the code in question it seems like the issue has already been addressed in git.

Given that the most recent version on hex.pm is version 1.5.8 is from 2021 and does not include the fix (and probably other code changes as well), and using the git version locally seems to work alright, it might be a good idea to release a new version.

@nathany-copia
Copy link

Also waiting for #290 for a small Elixir 1.17 fix.

You can use this for now, but this branch may disappear at some point if/when it gets merged:

{:absinthe_plug, "~> 1.5", github: "copia-wealth-studios/absinthe_plug", branch: "ci", override: true},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants