-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Date.parse() returns null instead of NaN #263
Comments
Ah, interesting quirk. |
The spec for
|
The native |
FWIW, the biggest issue with the difference is that it's not even safe to perform basic inequality operations on the result of For example, given |
Indeed. We're never going to be 100% compatible with the Native parse (ie - being a number) because... well.. that's the point of this library (to extend the native Date object). However this (returning Would require a SemVer Major though, potentially, as it's a breaking backwards compatible change. PRs welcome - as I'm snowed under with "real" work so OSS I'm afraid is low priority. |
After installing datejs
Date.parse()
returnsnull
instead ofNaN
This breaks compatibility with the stock
Date()
object which in turn breaks the conditional request logic in express.static causing spurious HTTP 412 responses.Gross hack work around
The text was updated successfully, but these errors were encountered: