Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility/form label #62

Open
david-morris opened this issue Aug 24, 2023 · 4 comments
Open

Accessibility/form label #62

david-morris opened this issue Aug 24, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@david-morris
Copy link
Contributor

It would be nice if it was possible to add an aria-label and/or HTML label.

The <FormLabel> Chakra component doesn't work with this, presumably because the input's ID is being set by whatever is doing the popover logic.

Since that's probably a lot of internal logic, it would be nice to be able to explicitly pass down an aria-label.

@aboveyunhai
Copy link
Owner

aboveyunhai commented Aug 24, 2023

@david-morris I think you can use id and inputProps to pass other attributes, inputProps inside propConfigs can override everything inside the input including id and others.

@david-morris
Copy link
Contributor Author

When I pass id in version 0.2.9, inspect element still says its id is "popover-trigger-:r8:".

@aboveyunhai
Copy link
Owner

aboveyunhai commented Aug 25, 2023

When I pass id in version 0.2.9, inspect element still says its id is "popover-trigger-:r8:".

oops, that's rough. Let me have a redesign for the whole input and popover trigger to follow the standard for the new version, the current popover over the entire input is actually a wrong design. That's why. Otherwise there is no way to handle it.

@david-morris
Copy link
Contributor Author

Thankfully what I'm building is not in the public sector and relies heavily on the user seeing and reading maps, so it's just Playwright trying to use the aria information (and there's workarounds).

@aboveyunhai aboveyunhai added the bug Something isn't working label Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants