Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the default state for range picker. #5

Open
aboveyunhai opened this issue Jan 27, 2022 · 1 comment
Open

the default state for range picker. #5

aboveyunhai opened this issue Jan 27, 2022 · 1 comment

Comments

@aboveyunhai
Copy link
Owner

aboveyunhai commented Jan 27, 2022

I made an immature decision to let the range state as an array [startDate, endDate], this will cause some issues when doing state management.

My original intent is to have a empty object if user don't provide their own:

{
  startDate: undefined, 
  endDate: undefined
}

but it will break range usage from previous versions.

@david-morris
Copy link
Contributor

david-morris commented Aug 9, 2022

I like this. It's more explicit. Caret ranges won't auto-increment "minor" versions before 1.0, (link) so it shouldn't cause users a problem until they explicitly update, as long as this is done with a "minor" change (such as 0.22 to 0.23) rather than "patch" change (such as 0.22.0 to 0.22.1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants