-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WEB-3364] Storybook migration: Add Storybook #302
Conversation
0fe68b7
to
86bf0d9
Compare
6c7eede
to
fe55d05
Compare
f14aa44
to
c4163aa
Compare
c4163aa
to
2282ad1
Compare
bb3ae39
to
956f1c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @jamiehenson (and @dpiatek), thanks so much!
A few small comments to give it some shine :)
- Squash the existing featured link fixup commit down
- Squash
chore: don't allow SB version ads or telemetry
intoAdd storybook scaffold
- Drop the first commit, then
chore: resolve preview merge commit and remove TW base layer usage
will be reduced to only the meganav test data comment, and can be squashed intofeat: port existing ably-ui content to SB stories, strip out TW layer…
(Be careful with the squashes, I can help if that would make it more comfortable)
…s where they conflict
…ore hljs safelisting
e0dbaa1
to
df8db05
Compare
@kennethkalmer done the squashing, thanks for the suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update (18/3/24), jamiehenson:
This PR fundamantally does the following things:
[COMPONENT_NAME].stories.tsx
files that contain Stories for each of the components represented in the Railsably-ui
@layer
directive as it was a blocker here (despite what various Storybook/Tailwind/PostCSS blogs and docs promise), and ultimately not something (in my view) that would necessitate the massive workarounds needed to make it play nice with SB.Cypress is inactive with this release, the tests need to be rewritten - probably as part of #323.
To test, pull down, grab the latest packages, and run
yarn storybook
from root.Original PR description:
Replace the preview server with Storybook.
Explore what kind of issues this kind of migration would encounter: