Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor lockStartRetryAttachLoop method #627

Open
sacOO7 opened this issue Jan 16, 2024 · 1 comment
Open

Refactor lockStartRetryAttachLoop method #627

sacOO7 opened this issue Jan 16, 2024 · 1 comment

Comments

@sacOO7
Copy link
Collaborator

sacOO7 commented Jan 16, 2024 •
edited by sync-by-unito bot
Loading 

Also -- why does lockStartRetryAttachLoop start off by moving the channel into the detached state? makes no sense
  • Seems we need to refactor this logic, not doing it as a part of no-connection-serial PR.
  • Check for related passing tests for no connection serial.

┆Issue is synchronized with this Jira Task by Unito
@sacOO7 sacOO7 changed the title Refactor lockStartRetryAttach method Refactor lockStartRetryAttachLoop method Jan 16, 2024
@sync-by-unito Sync by Unito
Copy link

sync-by-unito bot commented Jan 16, 2024

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-4034

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sacOO7