Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should assume the tier is PREVIEW when developing PL locally #25

Open
colingourlay opened this issue Aug 19, 2022 · 1 comment
Open

We should assume the tier is PREVIEW when developing PL locally #25

colingourlay opened this issue Aug 19, 2022 · 1 comment

Comments

@colingourlay
Copy link
Contributor

colingourlay commented Aug 19, 2022 •
edited
Loading

Currently we only match against "nucwed.aunty" and "presentation-layer.abc" for TIERS.PREVIEW.

https://github.com/abcnews/env-utils/blob/main/src/index.ts#L148-L151

We should add "localhost.abc" to cover local PL dev servers.

Currently that will return null from getTier(), which library users can take to mean either live or preview, depending on what their assumed default it.
@colingourlay
Copy link
Contributor Author

Tenants that should immediately be updated to reflect this change include terminus-fetch and odyssey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@colingourlay