Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ] Add a (GH-compliant) license file #1

Closed
MarcoRavich opened this issue Sep 17, 2024 · 2 comments
Closed

[REQ] Add a (GH-compliant) license file #1

MarcoRavich opened this issue Sep 17, 2024 · 2 comments

Comments

@MarcoRavich
Copy link

MarcoRavich commented Sep 17, 2024

Hi there, 1st of all thanks for this awesome work !

Since we've 'doxed' it in our HyMPS project (under AUDIO section \ AI-based category \ Enhancers page \ Aligners), can you please add a GH-compliant license file for it ?

As you know, expliciting licensing terms is extremely important to let anyone better/faster understand how to reuse/adapt/modify sources (and not only) in other open projects and vice-versa.

Although it may sounds like a minor aspect, license file omission obviously causes an inconsistent generation of the relative badge too:


(badge-generator URL: https://badgen.net/github/license/abargum/diff-apf)

You can easily set a standardized one through the GH's license wizard tool.

Last but not least, let us know how we could improve - in your opinion - our categorizations and links to resources in order to favor collaboration between developers (and therefore evolution) of listed projects.

Hope that helps/inspires !

@abargum
Copy link
Owner

abargum commented Sep 19, 2024

Hi Marco,

Thanks for writing and 'doxing' the APF project.
A license is now added making sure everyone can use it freely :)

@abargum abargum closed this as completed Sep 19, 2024
@MarcoRavich
Copy link
Author

Thanks, as you can see it works now !

I've also started a discussion about phases issues @ audalign that is getting interesting, so it would be really cool to have some expert developers - like you - intervene.

Last but not least, a question: can other projects (like @shiranaziz's Audio Enhancement from Multiple Crowdsourced Recordings or @yoongi43's Exploiting Time-Frequency Conformers for Music Audio Enhancement for example) could benefit from phase alignment in your opinion ?

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants