Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Morning Session Peer-to-Peer code review #21

Open
fuadmoin opened this issue Feb 9, 2023 · 1 comment
Open

Morning Session Peer-to-Peer code review #21

fuadmoin opened this issue Feb 9, 2023 · 1 comment

Comments

@fuadmoin
Copy link

fuadmoin commented Feb 9, 2023

Well done Abdulali Noori on your portfolio project. The project is complete and looking awesome. It rocks both on mobile and desktop versions.

The only things we suggest are:

  1. there is a typo in about me section
    Desktop Version:
    image

Mobile Version:
image

  1. It would be nice if you implement accessibility on the desktop version so that people who prefer to use a keyboard or a screen reader to access the website, can access your beautiful website easily.
@ab-noori
Copy link
Owner

ab-noori commented Feb 9, 2023

Hi, Mr. @fuadmoin,
Thanks for taking the time and reviewing my project, I will try my best to solve the issues. Your nice recommendations are appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fuadmoin @ab-noori