Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Week-3 : peer to peer code review #14

Open
Santosh-Konappanavar opened this issue Feb 2, 2023 · 2 comments
Open

Week-3 : peer to peer code review #14

Santosh-Konappanavar opened this issue Feb 2, 2023 · 2 comments

Comments

@Santosh-Konappanavar
Copy link
Collaborator

Review

  • You work hard and Did a very well job creating your portfolio.

  • It is responsive and it looks good.

suggestion

  • It would be better to use 100% width.
  • Use some Color contrast on the button.
  • it would be better to avoid a horizontal scroll bar at the bottom of your website.
@bilalrajput09
Copy link

bilalrajput09 commented Feb 2, 2023

Great job 👍 so far I do not see any problem I think you fix your horizontal
scroll bar by adding overflow-x : hidden in your root or reset settings in your css file

@danutibe07
Copy link

danutibe07 commented Feb 2, 2023

Great job so far using all the correct HTML tags and also making the pages responsive
But just like Mr Bilal said you should get rid of the overflow property on the x axis
Also the spellings on some of your headings are incorrect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants